Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nightly for cargo fmt in CI #2519

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Use nightly for cargo fmt in CI #2519

merged 1 commit into from
Jun 15, 2022

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jun 15, 2022 •
edited
Loading

Rustfmt CI currently does not pass on main with nightly, see #2517 (comment)

@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Jun 15, 2022
@curquiza curquiza added this to the v0.29.0 milestone Jun 15, 2022
@curquiza curquiza mentioned this pull request Jun 15, 2022
Merged
2 tasks
@curquiza curquiza requested a review from Kerollmops June 15, 2022 08:34
Kerollmops
Kerollmops approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 😮 Thank you!
bors merge

@curquiza curquiza mentioned this pull request Jun 15, 2022
Merged
@bors
Copy link
Contributor

bors bot commented Jun 15, 2022

Build succeeded:

@bors bors bot merged commit e46b853 into main Jun 15, 2022
bors bot added a commit that referenced this pull request Jun 15, 2022
@bors @curquiza
Merge #2520
49d5099 
2520: Use nightly for cargo fmt in CI (for `release-v0.28.0` branch) r=Kerollmops a=curquiza

Following #2519

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bors bors bot deleted the fix-rust-fmt branch June 15, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) v0.29.0 PRs/issues solved in v0.29.0 released on 2022-10-03
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curquiza @Kerollmops