-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format API keys in hexa instead of base64 #2584
Conversation
744245f
to
eb65a60
Compare
eb65a60
to
a146fd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! I am just awaiting @gmourier approval. Would it be possible to update the specs too @ManyTheFish?
This PR is directly related to this comment. It makes it possible for the users to generate the keys on their side, in a determinist way. I would like to inform the @meilisearch/integration-team and @meilisearch/docs-team, of these changes. However, if you didn't document this client-side key generation (by using hmac and base64...) you must ignore this message. if you are displaying the content of the key
field, note that we changed the encoding function and display a 64 chars hexadecimal lowercase string instead of a smaller base64 encoded string.
578: Bump uuid to 1.1.2 r=ManyTheFish a=Kerollmops Just to [align the version with Meilisearch](meilisearch/meilisearch#2584). Co-authored-by: Kerollmops <clement@meilisearch.com>
@meilisearch/docs-team @meilisearch/integration-team Know that the representation of a Now -> I think you may want to update code snippets or examples showing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests. |
This PR:
uuid
crate versionThe API key can now be generated in bash as below:
fixes the issue raised in product/discussion#421, this should not impact anything in documentation nor integration but ease the key generation on the user sides.
poke @gmourier