Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cache from test CI #3422

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Remove cache from test CI #3422

merged 3 commits into from
Jan 25, 2023

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jan 25, 2023 •
edited

Comment the lines in CIs where we use the test CIs
We indeed have cache issues (lack of space on the machine) when running our test CIs
#3403

@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 25, 2023
@curquiza curquiza added this to the v1.1.0 milestone Jan 25, 2023
@curquiza curquiza added bug Something isn't working as expected github actions Pull requests that update GitHub Actions code and removed bug Something isn't working as expected labels Jan 25, 2023
@curquiza curquiza requested a review from a team January 25, 2023 15:33
@curquiza curquiza changed the title Remove cache from Windows and macOs CIs Remove cache from test CI Jan 25, 2023
@curquiza @dureuill
Update .github/workflows/rust.yml
48dabd2 
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
dureuill
dureuill approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dureuill
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 25, 2023

Build succeeded:

@bors bors bot merged commit bfb1f92 into main Jan 25, 2023
@bors bors bot deleted the curquiza-patch-1 branch January 25, 2023 17:08
@curquiza curquiza mentioned this pull request Mar 13, 2023
Merged
bors bot added a commit that referenced this pull request Mar 13, 2023
@bors @curquiza
Merge #3587
7c9a8b1 
3587: Enable cache again in test suite CI r=curquiza a=curquiza

Following the change in this PR introduced in v1.1: #3422

The cache was removed due to failures (lack of space). Now the binary is smaller (from 250Mb to 50Mb) we want to try to enable the cache again.
Indeed, without the cache step, the CIs are wayyyy slower (45min instead of 20-30min).

For later: Rust 1.68 introduced a new way to fetch crates. Updating the rust version might also help in the future!

Co-authored-by: curquiza <clementine@meilisearch.com>
@meili-bot meili-bot added the v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03 label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
github actions Pull requests that update GitHub Actions code maintenance Issue about maintenance (CI, tests, refacto...) v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curquiza @dureuill @meili-bot