Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clippy happy for Rust 1.67, allow uninlined_format_args #3437

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

dureuill
Copy link
Contributor

Pull Request

This PR is the equivalent of #3434 for the release-v1.0.0 branch.

See #3434 for more information.

@dureuill dureuill added maintenance Issue about maintenance (CI, tests, refacto...) skip changelog The PR will not appear in the release changelogs labels Jan 31, 2023
Kerollmops
Kerollmops previously approved these changes Jan 31, 2023
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what you did there 🔥
bors merge

@bors
Copy link
Contributor

bors bot commented Jan 31, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@Kerollmops Kerollmops added this to the v1.0.0 milestone Jan 31, 2023
@dureuill dureuill changed the title Make clippy happy for Rust 1.67 Make clippy happy for Rust 1.67, , allow uninlined_format_args Jan 31, 2023
@dureuill dureuill changed the title Make clippy happy for Rust 1.67, , allow uninlined_format_args Make clippy happy for Rust 1.67, allow uninlined_format_args Jan 31, 2023
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the formatting is good now 😄
bors merge

bors bot added a commit to meilisearch/milli that referenced this pull request Jan 31, 2023
775: Fix clippy for Rust 1.67, allow `uninlined_format_args` r=curquiza a=dureuill

# Pull Request

milli part of meilisearch/meilisearch#3437

Co-authored-by: Louis Dureuil <louis@meilisearch.com>
bors bot added a commit to meilisearch/milli that referenced this pull request Jan 31, 2023
775: Fix clippy for Rust 1.67, allow `uninlined_format_args` r=dureuill a=dureuill

# Pull Request

milli part of meilisearch/meilisearch#3437

Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jan 31, 2023

@bors bors bot merged commit 544b581 into release-v1.0.0 Jan 31, 2023
@bors bors bot deleted the disable-clippy branch January 31, 2023 11:12
@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...) skip changelog The PR will not appear in the release changelogs v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants