-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scheduled test to Actions for all features #3510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jlucktay
Thanks a lot for the PR! Small changes needed
- can you only test this on Ubuntu (not windows and macOS) like we do in
test-linux
job? We use an Ubuntu container and not the nativeubuntu-18.04
of GitHub Action that will be soon deprecated - can you remove the empty line between each step of the job you added?
Add a new job to the Rust workflow to run 'cargo build' and 'cargo test' (on the cron schedule only) with the '--all-features' flag. This will execute across all three environments: Linux, macOS, Windows. Autoformat the Rust workflow file via the Red Hat YAML extension for Visual Studio Code: https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml This straightens out whitespace and string quoting for safer parsing. Fixes #3506.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jlucktay
Are you sure your CI is working, have you done any manual test?
Because I don't see the following steps in your jobs:
- name: Install needed dependencies
run: |
apt-get update && apt-get install -y curl
apt-get install build-essential -y
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
And they are in the other jobs using the ubuntu-18.04 Docker image
I triggered some runs on my fork about two weeks ago before I opened the PR, yes. The Actions runner images come with Rust, curl, and the build-essential package installed already, so those extra two steps do seem redundant, but I have included them now anyway. I have just run another fresh round of tests now. |
Yes so you tested 2 weeks ago with Thanks for the changes, I review this during the afternoon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
Stopped waiting for PR status (GitHub check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests. |
Uffizzi Preview |
Pull Request
Related issue
Fixes #3506.
What does this PR do?
Add a new job to the Rust workflow to run
cargo build
andcargo test
(on the cron schedule only) with the--all-features
flag.This will execute across all three environments: Linux, macOS, Windows.
Autoformat the Rust workflow file via the Red Hat YAML extension for Visual Studio Code.
This straightens out whitespace and string quoting for safer parsing.
As pointed out by @irevoire here, changes to CI such as this one will need to wait for #3496 before going ahead.
The new action was executed on my fork but ended up failing on some metrics tests, as called out in that linked comment.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!