Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduled test to Actions for all features #3510

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Add scheduled test to Actions for all features #3510

merged 4 commits into from
Mar 6, 2023

Conversation

jlucktay
Copy link
Contributor

Pull Request

Related issue

Fixes #3506.

What does this PR do?

Add a new job to the Rust workflow to run cargo build and cargo test (on the cron schedule only) with the --all-features flag.
This will execute across all three environments: Linux, macOS, Windows.

Autoformat the Rust workflow file via the Red Hat YAML extension for Visual Studio Code.
This straightens out whitespace and string quoting for safer parsing.

As pointed out by @irevoire here, changes to CI such as this one will need to wait for #3496 before going ahead.
The new action was executed on my fork but ended up failing on some metrics tests, as called out in that linked comment.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza self-requested a review February 28, 2023 18:49
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jlucktay

Thanks a lot for the PR! Small changes needed

  • can you only test this on Ubuntu (not windows and macOS) like we do in test-linux job? We use an Ubuntu container and not the native ubuntu-18.04 of GitHub Action that will be soon deprecated
  • can you remove the empty line between each step of the job you added?

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@curquiza curquiza added maintenance Issue about maintenance (CI, tests, refacto...) github actions Pull requests that update GitHub Actions code labels Mar 2, 2023
Add a new job to the Rust workflow to run 'cargo build' and 'cargo
test' (on the cron schedule only) with the '--all-features' flag.
This will execute across all three environments: Linux, macOS,
Windows.

Autoformat the Rust workflow file via the Red Hat YAML extension for
Visual Studio Code:
https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml
This straightens out whitespace and string quoting for safer parsing.

Fixes #3506.
@jlucktay jlucktay requested a review from curquiza March 3, 2023 12:09
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jlucktay

Are you sure your CI is working, have you done any manual test?

Because I don't see the following steps in your jobs:

- name: Install needed dependencies
        run: |
          apt-get update && apt-get install -y curl
          apt-get install build-essential -y
- uses: actions-rs/toolchain@v1
        with:
          toolchain: stable
          override: true

And they are in the other jobs using the ubuntu-18.04 Docker image

@jlucktay
Copy link
Contributor Author

jlucktay commented Mar 6, 2023

Hello @jlucktay

Are you sure your CI is working, have you done any manual test?

Because I don't see the following steps in your jobs:

- name: Install needed dependencies
        run: |
          apt-get update && apt-get install -y curl
          apt-get install build-essential -y
- uses: actions-rs/toolchain@v1
        with:
          toolchain: stable
          override: true

And they are in the other jobs using the ubuntu-18.04 Docker image

I triggered some runs on my fork about two weeks ago before I opened the PR, yes.

The Actions runner images come with Rust, curl, and the build-essential package installed already, so those extra two steps do seem redundant, but I have included them now anyway.

I have just run another fresh round of tests now.

@jlucktay jlucktay requested a review from curquiza March 6, 2023 12:48
@curquiza
Copy link
Member

curquiza commented Mar 6, 2023

I triggered some runs on my fork about two weeks ago before I opened the PR, yes.

Yes so you tested 2 weeks ago with ubuntu-18.04 provided by GitHub and not the changes I asked with the docker image ubuntu-18.04. Because it does not work without these 2 steps 😊

Thanks for the changes, I review this during the afternoon

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlucktay

Looks good to me!

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@curquiza curquiza added this to the v1.2.0 milestone Mar 6, 2023
@curquiza
Copy link
Member

curquiza commented Mar 6, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

Stopped waiting for PR status (GitHub check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Uffizzi Preview deployment-18245 was deleted.

@bors bors bot merged commit df3986c into meilisearch:main Mar 6, 2023
@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Pull requests that update GitHub Actions code maintenance Issue about maintenance (CI, tests, refacto...) v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the all features in the CI
3 participants