Improve the health route by ensuring lmdb is not down #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
force-pushed
the
fix-the-health-route
branch
2 times, most recently
from
0c9481a
to
c36338f
Compare
And refactorize slightly the auth controller.
irevoire
force-pushed
the
fix-the-health-route
branch
from
c36338f
to
4d308d5
Compare
Uffizzi Ephemeral Environment
|
Kerollmops
approved these changes
Apr 6, 2023
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3644
In this PR, I try to make a small read on the
AuthControllerandIndexSchedulerdatabases.The idea is not to validate that everything works but just to avoid the bug we had last time when lmdb was stuck forever.
In order to get access to the
AuthControllerwithout going through the extractor, I need to wrap it in theDatatype fromactix-web.And to do that, I had to patch our extractor so it works with the
Datatype as well.