Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add final dot #3755

Merged
merged 1 commit into from
May 16, 2023
Merged

Re-add final dot #3755

merged 1 commit into from
May 16, 2023

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented May 16, 2023 •
edited
Loading

I removed the final dot of the error message in my last PR, this one re-adds it.

related to #3749

Oups 馃槵

@ManyTheFish ManyTheFish added the bug Something isn't working as expected label May 16, 2023
@ManyTheFish ManyTheFish added this to the v1.2.0 milestone May 16, 2023
@ManyTheFish ManyTheFish requested a review from curquiza May 16, 2023 08:59
curquiza
curquiza approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 16, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 1e762d1 into release-v1.2.0 May 16, 2023
7 checks passed
@meili-bors meili-bors bot deleted the fix-back-sort-error-code branch May 16, 2023 10:46
@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ManyTheFish @curquiza @meili-bot