New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish-post-release.yml
CI workflow
#3794
Conversation
@@ -122,7 +122,7 @@ jobs: | |||
- name: Install pipenv | |||
uses: dschep/install-pipenv-action@v1 | |||
- name: Install dependencies | |||
run: pipenv install --dev --python=${{ matrix.python-version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix
is not defined.
on: | ||
release: | ||
types: [released] | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the ability to start this CI workflow manually might come handy?
# This workflow is reusable, i.e. it may be called from another workflow. | ||
# See https://docs.github.com/en/actions/using-workflows/reusing-workflows | ||
workflow_call: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is optional. It might be useful to be able to run this workflow manually though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vvv
just a quick review before a deeper one: can you put the changes related to the check-release.sh
script in another PR?
Thanks again for the PR
It's not related to the purpose of this one, if I understand correctly.
@curquiza Sure. Do I need to create an issue for that, or a PR will suffice? |
@curquiza Gentle reminder. 😇 |
Hello @vvv |
@curquiza Understood. Thanks for the explanation. However small Meilisearch team is, you folks are doing sterling work at prioritizing and focusing! The product looks great, the documentation is a beaut, and my contribution experience has been nothing but pleasant so far. ❤️ |
New CI workflow is triggered when a release is published, or a pre-release is changed to a released. It can also be triggered manually. `publish-post-release.yml` calls `publish-binaries.yml` and `publish-docker-images.yml` --- they are made reusable for this purpose. Once both workflows succeed, `publish-apt-brew-pkg.yml` is called. Closes meilisearch#3146
Hello @vvv In any case, I keep your solution in mind: I get your suggestions, I just don't know how it works in every situation, and I'm sure I will be able to refer to it in the future. Sorry to close this PR, and thank you again for your time. It's definitely not lost ❤️ |
@curquiza No problem. I trust your judgment. Cheers! |
New CI workflow is triggered when a release is published, or a pre-release
is changed to a released. It can also be triggered manually.
publish-post-release.yml
callspublish-binaries.yml
andpublish-docker-images.yml
--- they are made reusable for this purpose.Once both workflows succeed,
publish-apt-brew-pkg.yml
is called.Closes #3146
Other changes
matrix
reference in.github/workflows/sdks-tests.yml
.