Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the way words are counted in the word count DB #3824

Merged
merged 3 commits into from Jun 8, 2023
Merged

Changes the way words are counted in the word count DB #3824

merged 3 commits into from Jun 8, 2023

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Jun 8, 2023 •
edited

Pull Request

Related issue

Fixes #3823

What does this PR do?

  • Apply offset when parsing query that is consistent with the indexing

DB breaking changes

  • Count the number of words in field_id_word_count_docids
  • raise limit of word count for storing the entry in the DB from 10 to 30

@dureuill dureuill added this to the v1.3.0 milestone Jun 8, 2023
@dureuill dureuill requested a review from ManyTheFish June 8, 2023 09:58
ManyTheFish
ManyTheFish approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 8, 2023

Build succeeded:

@dureuill dureuill merged commit 047d22f into main Jun 8, 2023
10 checks passed
@dureuill dureuill deleted the word_count_db branch June 8, 2023 14:09
@meili-bot meili-bot added the v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31 label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Exactness does not match correctly in presence of hard separators
3 participants
@dureuill @ManyTheFish @meili-bot