Display the total number of tasks matching a filter/query #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Kerollmops
force-pushed
the
display-total-number-tasks
branch
3 times, most recently
from
77a73a6
to
d406bd2
Compare
dureuill
reviewed
Jul 6, 2023
dureuill
reviewed
Jul 6, 2023
Kerollmops
force-pushed
the
display-total-number-tasks
branch
from
ae64968
to
779a3f4
Compare
Kerollmops
force-pushed
the
display-total-number-tasks
branch
from
779a3f4
to
2276280
Compare
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns a new field on the
/tasksroutes. Thetotalfield exposes the total number of tasks that matches the given filter/query. It is useful to display information on a user interface and can help understand when progress is made in processing tasks, i.e., the total number of tasks on/tasks?statuses=succeededwill increase over time.Fixes #3888.
/tasksspecs route.How have I implemented it?
I found it much easier to run two times the task filtering system. Once with the original
fromandlimitparameters and a second time without. The second call will return the total number of tasks that match the query, not only the number of tasks on the current page.So far, in terms of performance, there doesn't seem to be any issue. I tried different filters with something like 250k tasks. Note that there is a limit of 1M tasks in the queue.