Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry for define field to search on at query time #3907

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Add telemetry for define field to search on at query time #3907

merged 3 commits into from
Jul 13, 2023

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Jul 10, 2023 •
edited
Loading

Add "attributes_to_search_on" telemetry usage counter:

"attributes_to_search_on": {
   "total_number_of_use": 12,
},

This measures the number of search queries that the user uses attributesToSearchOn field.

related to meilisearch/specifications#251

reviewers:

@ManyTheFish ManyTheFish changed the title Add telemetry Add telemetry for define field to search on at query time Jul 10, 2023
@gillian-meilisearch gillian-meilisearch added this to the v1.3.0 milestone Jul 12, 2023
@ManyTheFish
Copy link
Member Author

Hello. @macraig and @dureuill, I fixed the PR change requests

@ManyTheFish ManyTheFish force-pushed the add-telemetry-define-attributes-to-search-on branch from 0475d2f to 359b902 Compare July 13, 2023 09:38
dureuill
dureuill approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦝

@dureuill
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 13, 2023

Build succeeded:

@ManyTheFish ManyTheFish merged commit 657f24e into release-v1.3.0 Jul 13, 2023
10 checks passed
@ManyTheFish ManyTheFish deleted the add-telemetry-define-attributes-to-search-on branch July 13, 2023 11:00
@meili-bot meili-bot added the v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31 label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macraig macraig macraig approved these changes

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ManyTheFish @dureuill @macraig @meili-bot @gillian-meilisearch