Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix score details casing #3949

Merged
merged 1 commit into from Jul 26, 2023
Merged

Fix score details casing #3949

merged 1 commit into from Jul 26, 2023

Conversation

ManyTheFish
Copy link
Member

Pull Request

Fixes #3941

@ManyTheFish ManyTheFish changed the base branch from main to release-v1.3.0 July 25, 2023 13:50
@ManyTheFish ManyTheFish added this to the v1.3.0 milestone Jul 25, 2023
@ManyTheFish ManyTheFish added the bug Something isn't working as expected label Jul 25, 2023
@Kerollmops
Copy link
Member

bors try

meili-bors bot added a commit that referenced this pull request Jul 25, 2023
@meili-bors
Try #3949:
8cf449c
Kerollmops
Kerollmops requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it attributeRankingOrderScore or attributeRankingOrder?

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 25, 2023

try

Build succeeded:

@ManyTheFish
Copy link
Member Author

Linking the final choice:
https://github.com/meilisearch/specifications/pull/252/files#r1273984997

Kerollmops
Kerollmops approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🦪
bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 26, 2023

Build succeeded:

@ManyTheFish ManyTheFish merged commit 939b2fc into release-v1.3.0 Jul 26, 2023
2 checks passed
@ManyTheFish ManyTheFish deleted the fix-score-details-casing branch July 26, 2023 14:57
@meili-bot meili-bot added the v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31 label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Attribute casing in score details is snake_case instead of expected camelCase
3 participants
@ManyTheFish @Kerollmops @meili-bot