-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to heed 0.20 #4223
Merged
Merged
Update to heed 0.20 #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f1d247
to
0d44826
Compare
972da0e
to
b762d19
Compare
6ba31b7
to
22ec6d9
Compare
22ec6d9
to
58dac8a
Compare
/benchmark search_wiki |
/benchmark search_songs |
Here are your search_songs benchmarks diff 👊
|
Here are your search_wiki benchmarks diff 👊
|
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
Kerollmops
commented
Nov 28, 2023
dureuill
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the v0.20-alpha.9 version of heed into Meilisearch 🎉 The main goal is to test it in a real environment to make the necessary changes if needed. We also want to merge it as soon as possible during the pre-release phase to ensure we catch bugs before the release.
Most of the calls to heed are the same as before, except:
PolyDatabase
has been replaced with aDatabase<Unspecified, Unspecified>
. We replaced theget<T, U>()
by aremap<T, U>().get()
calls.Database
append(...)
method has been replaced with aput_with_flags(PutFlags::APPEND, ...)
.RwTxn<'e, 'p>
has been simplified into aRwTxn<'e>
.BytesEncode/Decode
traits return aResult<_, BoxedError>
instead of anOption<_>
.BEU32
integer when storing/getting them from heed.TODO
Follow-up work
SerializationError
internal error variant.