Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to heed 0.20 #4223

Merged
merged 14 commits into from
Nov 28, 2023
Merged

Update to heed 0.20 #4223

merged 14 commits into from
Nov 28, 2023

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Nov 22, 2023

This PR brings the v0.20-alpha.9 version of heed into Meilisearch 🎉 The main goal is to test it in a real environment to make the necessary changes if needed. We also want to merge it as soon as possible during the pre-release phase to ensure we catch bugs before the release.

Most of the calls to heed are the same as before, except:

  • The PolyDatabase has been replaced with a Database<Unspecified, Unspecified>. We replaced the get<T, U>() by a remap<T, U>().get() calls.
  • The Database append(...) method has been replaced with a put_with_flags(PutFlags::APPEND, ...).
  • The RwTxn<'e, 'p> has been simplified into a RwTxn<'e>.
  • The BytesEncode/Decode traits return a Result<_, BoxedError> instead of an Option<_>.
  • We no longer need to wrap and unwrap the BEU32 integer when storing/getting them from heed.

TODO

  • Create actual, simple error types instead of using strings in the codecs.

Follow-up work

  • Move the codecs into another member crate (we depend on the uuid one in the meilitool crate).
  • Display the internal decoding error in the SerializationError internal error variant.

@Kerollmops Kerollmops force-pushed the update-heed-0.20 branch 2 times, most recently from 972da0e to b762d19 Compare November 23, 2023 13:01
@Kerollmops Kerollmops force-pushed the update-heed-0.20 branch 2 times, most recently from 6ba31b7 to 22ec6d9 Compare November 23, 2023 13:56
@Kerollmops Kerollmops marked this pull request as ready for review November 23, 2023 14:09
@Kerollmops Kerollmops added this to the v1.6.0 milestone Nov 23, 2023
@Kerollmops Kerollmops added the enhancement New feature or improvement label Nov 23, 2023
@Kerollmops
Copy link
Member Author

/benchmark search_wiki

@Kerollmops
Copy link
Member Author

/benchmark search_songs

@meili-bot
Copy link
Contributor

Here are your search_songs benchmarks diff 👊

group                                                                                                    search_songs_main_b366acda             search_songs_update-heed-0.20_b366acda
-----                                                                                                    --------------------------             --------------------------------------
smol-songs.csv: asc + default/Notstandskomitee                                                           1.00      2.3±0.01ms        ? ?/sec    1.27      2.9±0.01ms        ? ?/sec
smol-songs.csv: asc + default/charles                                                                    1.00    727.2±3.55µs        ? ?/sec    1.00    725.6±2.73µs        ? ?/sec
smol-songs.csv: asc + default/charles mingus                                                             1.01   1082.8±7.55µs        ? ?/sec    1.00   1071.7±6.63µs        ? ?/sec
smol-songs.csv: asc + default/david                                                                      1.00   1179.2±7.39µs        ? ?/sec    1.00   1179.4±9.35µs        ? ?/sec
smol-songs.csv: asc + default/david bowie                                                                1.00   1478.0±9.17µs        ? ?/sec    1.01   1486.2±6.86µs        ? ?/sec
smol-songs.csv: asc + default/john                                                                       1.00    600.8±3.40µs        ? ?/sec    1.00    602.5±3.84µs        ? ?/sec
smol-songs.csv: asc + default/marcus miller                                                              1.01   1885.4±8.17µs        ? ?/sec    1.00   1871.8±6.82µs        ? ?/sec
smol-songs.csv: asc + default/michael jackson                                                            1.01  1592.0±10.05µs        ? ?/sec    1.00  1575.4±11.62µs        ? ?/sec
smol-songs.csv: asc + default/tamo                                                                       1.00    802.8±6.23µs        ? ?/sec    1.01    808.0±4.36µs        ? ?/sec
smol-songs.csv: asc + default/thelonious monk                                                            1.00      3.1±0.01ms        ? ?/sec    1.18      3.6±0.02ms        ? ?/sec
smol-songs.csv: asc/Notstandskomitee                                                                     1.00      2.3±0.01ms        ? ?/sec    1.26      2.9±0.01ms        ? ?/sec
smol-songs.csv: asc/charles                                                                              1.00    383.8±2.75µs        ? ?/sec    1.00    384.7±1.84µs        ? ?/sec
smol-songs.csv: asc/charles mingus                                                                       1.00    549.6±3.71µs        ? ?/sec    1.00    550.9±3.33µs        ? ?/sec
smol-songs.csv: asc/david                                                                                1.01    616.7±4.28µs        ? ?/sec    1.00    613.2±4.90µs        ? ?/sec
smol-songs.csv: asc/david bowie                                                                          1.00    765.6±2.61µs        ? ?/sec    1.00    765.8±3.07µs        ? ?/sec
smol-songs.csv: asc/john                                                                                 1.00    465.6±2.72µs        ? ?/sec    1.01    469.4±2.48µs        ? ?/sec
smol-songs.csv: asc/marcus miller                                                                        1.00    600.2±4.06µs        ? ?/sec    1.00    598.6±3.67µs        ? ?/sec
smol-songs.csv: asc/michael jackson                                                                      1.00    731.0±4.73µs        ? ?/sec    1.00    732.2±3.84µs        ? ?/sec
smol-songs.csv: asc/tamo                                                                                 1.00    807.2±4.35µs        ? ?/sec    1.00    805.1±5.74µs        ? ?/sec
smol-songs.csv: asc/thelonious monk                                                                      1.00      2.4±0.01ms        ? ?/sec    1.24      3.0±0.01ms        ? ?/sec
smol-songs.csv: basic filter: <=/Notstandskomitee                                                        1.00      2.1±0.01ms        ? ?/sec    1.29      2.7±0.01ms        ? ?/sec
smol-songs.csv: basic filter: <=/charles                                                                 1.01    196.9±1.40µs        ? ?/sec    1.00    195.5±1.14µs        ? ?/sec
smol-songs.csv: basic filter: <=/charles mingus                                                          1.00    346.2±1.78µs        ? ?/sec    1.00    346.6±2.29µs        ? ?/sec
smol-songs.csv: basic filter: <=/david                                                                   1.01    248.0±1.82µs        ? ?/sec    1.00    246.1±1.81µs        ? ?/sec
smol-songs.csv: basic filter: <=/david bowie                                                             1.01    387.6±1.79µs        ? ?/sec    1.00    384.1±1.90µs        ? ?/sec
smol-songs.csv: basic filter: <=/john                                                                    1.02     43.1±0.39µs        ? ?/sec    1.00     42.5±0.39µs        ? ?/sec
smol-songs.csv: basic filter: <=/marcus miller                                                           1.00    381.3±1.87µs        ? ?/sec    1.00    382.5±3.94µs        ? ?/sec
smol-songs.csv: basic filter: <=/michael jackson                                                         1.00    408.6±2.49µs        ? ?/sec    1.00    407.5±3.34µs        ? ?/sec
smol-songs.csv: basic filter: <=/tamo                                                                    1.00    111.7±0.60µs        ? ?/sec    1.00    112.1±0.80µs        ? ?/sec
smol-songs.csv: basic filter: <=/thelonious monk                                                         1.00      2.2±0.01ms        ? ?/sec    1.27      2.8±0.01ms        ? ?/sec
smol-songs.csv: basic filter: TO/Notstandskomitee                                                        1.00      2.1±0.01ms        ? ?/sec    1.29      2.7±0.04ms        ? ?/sec
smol-songs.csv: basic filter: TO/charles                                                                 1.00    204.1±1.57µs        ? ?/sec    1.01    205.7±2.08µs        ? ?/sec
smol-songs.csv: basic filter: TO/charles mingus                                                          1.00    354.9±1.85µs        ? ?/sec    1.01    357.0±2.31µs        ? ?/sec
smol-songs.csv: basic filter: TO/david                                                                   1.01    255.8±2.13µs        ? ?/sec    1.00    254.2±1.64µs        ? ?/sec
smol-songs.csv: basic filter: TO/david bowie                                                             1.01    397.7±2.44µs        ? ?/sec    1.00    392.6±3.11µs        ? ?/sec
smol-songs.csv: basic filter: TO/john                                                                    1.02     52.8±0.63µs        ? ?/sec    1.00     51.8±0.35µs        ? ?/sec
smol-songs.csv: basic filter: TO/marcus miller                                                           1.00    391.2±2.75µs        ? ?/sec    1.00    391.4±5.71µs        ? ?/sec
smol-songs.csv: basic filter: TO/michael jackson                                                         1.00    414.5±2.79µs        ? ?/sec    1.01    417.8±3.20µs        ? ?/sec
smol-songs.csv: basic filter: TO/tamo                                                                    1.00    120.2±0.77µs        ? ?/sec    1.01    121.6±2.10µs        ? ?/sec
smol-songs.csv: basic filter: TO/thelonious monk                                                         1.00      2.2±0.01ms        ? ?/sec    1.27      2.8±0.01ms        ? ?/sec
smol-songs.csv: basic placeholder/                                                                       1.01     34.0±0.25µs        ? ?/sec    1.00     33.5±0.23µs        ? ?/sec
smol-songs.csv: basic with quote/"Notstandskomitee"                                                      1.02    133.4±0.77µs        ? ?/sec    1.00    131.2±0.75µs        ? ?/sec
smol-songs.csv: basic with quote/"charles"                                                               1.00    321.6±1.70µs        ? ?/sec    1.00    321.7±1.94µs        ? ?/sec
smol-songs.csv: basic with quote/"charles" "mingus"                                                      1.01    381.5±2.37µs        ? ?/sec    1.00    377.2±5.49µs        ? ?/sec
smol-songs.csv: basic with quote/"david"                                                                 1.00    508.1±3.19µs        ? ?/sec    1.00    505.9±3.80µs        ? ?/sec
smol-songs.csv: basic with quote/"david" "bowie"                                                         1.01    810.1±5.74µs        ? ?/sec    1.00    800.7±3.80µs        ? ?/sec
smol-songs.csv: basic with quote/"john"                                                                  1.00    802.4±3.67µs        ? ?/sec    1.00    803.5±3.72µs        ? ?/sec
smol-songs.csv: basic with quote/"marcus" "miller"                                                       1.00    264.8±1.86µs        ? ?/sec    1.01    266.8±1.94µs        ? ?/sec
smol-songs.csv: basic with quote/"michael" "jackson"                                                     1.01    779.6±8.48µs        ? ?/sec    1.00    770.5±3.61µs        ? ?/sec
smol-songs.csv: basic with quote/"tamo"                                                                  1.00    179.6±1.15µs        ? ?/sec    1.01    181.3±2.99µs        ? ?/sec
smol-songs.csv: basic with quote/"thelonious" "monk"                                                     1.00    423.3±2.29µs        ? ?/sec    1.00    423.6±2.38µs        ? ?/sec
smol-songs.csv: basic without quote/Notstandskomitee                                                     1.00      2.2±0.01ms        ? ?/sec    1.27      2.8±0.01ms        ? ?/sec
smol-songs.csv: basic without quote/charles                                                              1.00    668.8±4.74µs        ? ?/sec    1.01    676.8±6.94µs        ? ?/sec
smol-songs.csv: basic without quote/charles mingus                                                       1.00    931.0±4.33µs        ? ?/sec    1.01   937.4±10.66µs        ? ?/sec
smol-songs.csv: basic without quote/david                                                                1.00  1387.2±11.01µs        ? ?/sec    1.01   1400.3±9.24µs        ? ?/sec
smol-songs.csv: basic without quote/david bowie                                                          1.00   1436.1±9.41µs        ? ?/sec    1.01   1445.4±8.97µs        ? ?/sec
smol-songs.csv: basic without quote/john                                                                 1.00      2.7±0.01ms        ? ?/sec    1.02      2.7±0.01ms        ? ?/sec
smol-songs.csv: basic without quote/marcus miller                                                        1.00  1425.1±10.73µs        ? ?/sec    1.00  1419.3±16.51µs        ? ?/sec
smol-songs.csv: basic without quote/michael jackson                                                      1.00   1389.5±8.45µs        ? ?/sec    1.00   1384.8±9.31µs        ? ?/sec
smol-songs.csv: basic without quote/tamo                                                                 1.00    412.0±2.79µs        ? ?/sec    1.00    411.6±3.93µs        ? ?/sec
smol-songs.csv: basic without quote/thelonious monk                                                      1.00      3.0±0.01ms        ? ?/sec    1.19      3.6±0.01ms        ? ?/sec
smol-songs.csv: big filter/Notstandskomitee                                                              1.00      2.2±0.01ms        ? ?/sec    1.27      2.8±0.01ms        ? ?/sec
smol-songs.csv: big filter/charles                                                                       1.01    303.8±2.33µs        ? ?/sec    1.00    301.4±5.47µs        ? ?/sec
smol-songs.csv: big filter/charles mingus                                                                1.01    459.4±2.52µs        ? ?/sec    1.00    456.7±3.76µs        ? ?/sec
smol-songs.csv: big filter/david                                                                         1.00    561.8±3.28µs        ? ?/sec    1.00    561.2±5.16µs        ? ?/sec
smol-songs.csv: big filter/david bowie                                                                   1.00   1005.7±7.62µs        ? ?/sec    1.00   1004.3±7.50µs        ? ?/sec
smol-songs.csv: big filter/john                                                                          1.00    346.3±1.59µs        ? ?/sec    1.00    347.1±1.86µs        ? ?/sec
smol-songs.csv: big filter/marcus miller                                                                 1.01    493.8±3.49µs        ? ?/sec    1.00    490.6±4.91µs        ? ?/sec
smol-songs.csv: big filter/michael jackson                                                               1.01   973.2±12.15µs        ? ?/sec    1.00   967.4±39.61µs        ? ?/sec
smol-songs.csv: big filter/tamo                                                                          1.00    209.1±1.51µs        ? ?/sec    1.00    208.6±1.43µs        ? ?/sec
smol-songs.csv: big filter/thelonious monk                                                               1.00      2.3±0.01ms        ? ?/sec    1.25      2.9±0.01ms        ? ?/sec
smol-songs.csv: desc + default/Notstandskomitee                                                          1.00      2.3±0.01ms        ? ?/sec    1.26      2.9±0.01ms        ? ?/sec
smol-songs.csv: desc + default/charles                                                                   1.00    620.5±3.64µs        ? ?/sec    1.01    627.6±3.90µs        ? ?/sec
smol-songs.csv: desc + default/charles mingus                                                            1.00    957.2±3.58µs        ? ?/sec    1.01    970.4±7.44µs        ? ?/sec
smol-songs.csv: desc + default/david                                                                     1.00  1205.2±10.50µs        ? ?/sec    1.00   1207.2±7.20µs        ? ?/sec
smol-songs.csv: desc + default/david bowie                                                               1.01   1616.5±7.61µs        ? ?/sec    1.00   1599.7±8.31µs        ? ?/sec
smol-songs.csv: desc + default/john                                                                      1.01    829.8±6.24µs        ? ?/sec    1.00    821.3±4.09µs        ? ?/sec
smol-songs.csv: desc + default/marcus miller                                                             1.00   1600.9±8.13µs        ? ?/sec    1.00  1607.1±20.02µs        ? ?/sec
smol-songs.csv: desc + default/michael jackson                                                           1.00  1410.3±10.20µs        ? ?/sec    1.00  1408.0±10.80µs        ? ?/sec
smol-songs.csv: desc + default/tamo                                                                      1.00    973.1±5.36µs        ? ?/sec    1.00    971.3±3.52µs        ? ?/sec
smol-songs.csv: desc + default/thelonious monk                                                           1.00      2.7±0.01ms        ? ?/sec    1.22      3.3±0.01ms        ? ?/sec
smol-songs.csv: desc/Notstandskomitee                                                                    1.00      2.3±0.01ms        ? ?/sec    1.26      2.9±0.01ms        ? ?/sec
smol-songs.csv: desc/charles                                                                             1.00    383.9±2.65µs        ? ?/sec    1.00    384.3±3.03µs        ? ?/sec
smol-songs.csv: desc/charles mingus                                                                      1.00    552.9±4.18µs        ? ?/sec    1.00    555.6±4.29µs        ? ?/sec
smol-songs.csv: desc/david                                                                               1.01    616.8±3.23µs        ? ?/sec    1.00    610.3±5.90µs        ? ?/sec
smol-songs.csv: desc/david bowie                                                                         1.00    766.4±4.50µs        ? ?/sec    1.00    767.2±3.23µs        ? ?/sec
smol-songs.csv: desc/john                                                                                1.00    466.1±3.18µs        ? ?/sec    1.01    468.9±2.31µs        ? ?/sec
smol-songs.csv: desc/marcus miller                                                                       1.00    597.0±3.59µs        ? ?/sec    1.01    603.0±3.32µs        ? ?/sec
smol-songs.csv: desc/michael jackson                                                                     1.00    735.4±6.52µs        ? ?/sec    1.00    734.2±7.90µs        ? ?/sec
smol-songs.csv: desc/tamo                                                                                1.00    816.5±5.55µs        ? ?/sec    1.01    822.5±9.45µs        ? ?/sec
smol-songs.csv: desc/thelonious monk                                                                     1.00      2.4±0.01ms        ? ?/sec    1.24      3.0±0.02ms        ? ?/sec
smol-songs.csv: prefix search/a                                                                          1.00      2.0±0.01ms        ? ?/sec    1.00   1999.4±7.62µs        ? ?/sec
smol-songs.csv: prefix search/b                                                                          1.01   1488.5±9.94µs        ? ?/sec    1.00   1476.1±8.19µs        ? ?/sec
smol-songs.csv: prefix search/i                                                                          1.00      2.6±0.01ms        ? ?/sec    1.00      2.6±0.01ms        ? ?/sec
smol-songs.csv: prefix search/s                                                                          1.00  1817.3±36.32µs        ? ?/sec    1.00   1814.3±8.59µs        ? ?/sec
smol-songs.csv: prefix search/x                                                                          1.00   1040.9±6.40µs        ? ?/sec    1.01   1047.8±9.08µs        ? ?/sec
smol-songs.csv: proximity/7000 Danses Un Jour Dans Notre Vie                                             1.01   1070.1±7.77µs        ? ?/sec    1.00  1060.8±13.68µs        ? ?/sec
smol-songs.csv: proximity/The Disneyland Sing-Along Chorus                                               1.00      3.8±0.02ms        ? ?/sec    1.00      3.8±0.02ms        ? ?/sec
smol-songs.csv: proximity/Under Great Northern Lights                                                    1.00   1881.3±8.16µs        ? ?/sec    1.00  1888.8±10.67µs        ? ?/sec
smol-songs.csv: proximity/black saint sinner lady                                                        1.00      4.0±0.01ms        ? ?/sec    1.01      4.0±0.02ms        ? ?/sec
smol-songs.csv: proximity/les dangeureuses 1960                                                          1.05      3.3±0.01ms        ? ?/sec    1.00      3.1±0.01ms        ? ?/sec
smol-songs.csv: typo/Arethla Franklin                                                                    1.01    548.7±3.90µs        ? ?/sec    1.00    542.5±3.41µs        ? ?/sec
smol-songs.csv: typo/Disnaylande                                                                         1.00      2.2±0.01ms        ? ?/sec    1.27      2.8±0.01ms        ? ?/sec
smol-songs.csv: typo/dire straights                                                                      1.00      2.8±0.01ms        ? ?/sec    1.01      2.8±0.01ms        ? ?/sec
smol-songs.csv: typo/fear of the duck                                                                    1.01    516.9±3.85µs        ? ?/sec    1.00    512.8±3.63µs        ? ?/sec
smol-songs.csv: typo/indochie                                                                            1.01    182.9±1.34µs        ? ?/sec    1.00    180.9±1.36µs        ? ?/sec
smol-songs.csv: typo/indochien                                                                           1.00   1974.6±9.34µs        ? ?/sec    1.27      2.5±0.01ms        ? ?/sec
smol-songs.csv: typo/klub des loopers                                                                    1.01    566.6±4.14µs        ? ?/sec    1.00    558.3±3.49µs        ? ?/sec
smol-songs.csv: typo/michel depech                                                                       1.00    805.0±6.04µs        ? ?/sec    1.00    804.3±6.87µs        ? ?/sec
smol-songs.csv: typo/mongus                                                                              1.01    240.3±1.64µs        ? ?/sec    1.00    236.9±1.27µs        ? ?/sec
smol-songs.csv: typo/stromal                                                                             1.00    232.8±1.42µs        ? ?/sec    1.00    232.4±3.33µs        ? ?/sec
smol-songs.csv: typo/the white striper                                                                   1.01    888.9±4.13µs        ? ?/sec    1.00    877.9±9.69µs        ? ?/sec
smol-songs.csv: typo/thelonius monk                                                                      1.00      2.3±0.01ms        ? ?/sec    1.25      2.8±0.01ms        ? ?/sec
smol-songs.csv: words/7000 Danses / Le Baiser / je me trompe de mots                                     1.00   1074.3±7.14µs        ? ?/sec    1.09  1168.1±33.35µs        ? ?/sec
smol-songs.csv: words/Bring Your Daughter To The Slaughter but now this is not part of the title         1.00      4.6±0.02ms        ? ?/sec    1.02      4.7±0.04ms        ? ?/sec
smol-songs.csv: words/The Disneyland Children's Sing-Alone song                                          1.00      4.2±0.01ms        ? ?/sec    1.00      4.2±0.02ms        ? ?/sec
smol-songs.csv: words/les liaisons dangeureuses 1793                                                     1.00      3.2±0.01ms        ? ?/sec    1.00      3.2±0.01ms        ? ?/sec
smol-songs.csv: words/seven nation mummy                                                                 1.01  1126.5±18.00µs        ? ?/sec    1.00   1120.7±9.04µs        ? ?/sec
smol-songs.csv: words/the black saint and the sinner lady and the good doggo                             1.00      3.0±0.01ms        ? ?/sec    1.05      3.1±0.01ms        ? ?/sec
smol-songs.csv: words/whathavenotnsuchforth and a good amount of words to pop to match the first one     1.00      2.2±0.03ms        ? ?/sec    1.24      2.7±0.01ms        ? ?/sec

@meili-bot
Copy link
Contributor

Here are your search_wiki benchmarks diff 👊

group                                                                                    search_wiki_main_b366acda              search_wiki_update-heed-0.20_b366acda
-----                                                                                    -------------------------              -------------------------------------
smol-wiki-articles.csv: basic placeholder/                                               1.01     18.5±0.33µs        ? ?/sec    1.00     18.2±0.16µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"film"                                          1.00      2.0±0.01ms        ? ?/sec    1.00      2.0±0.01ms        ? ?/sec
smol-wiki-articles.csv: basic with quote/"france"                                        1.00   1259.8±7.75µs        ? ?/sec    1.00   1255.8±6.39µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"japan"                                         1.00    775.8±4.04µs        ? ?/sec    1.05    817.7±2.59µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"machine"                                       1.01    407.7±3.04µs        ? ?/sec    1.00    401.8±9.69µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"miles" "davis"                                 1.00    815.2±3.92µs        ? ?/sec    1.00    814.0±5.25µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"mingus"                                        1.01    200.7±1.24µs        ? ?/sec    1.00    199.0±1.44µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"rock" "and" "roll"                             1.00   1874.5±9.65µs        ? ?/sec    1.00  1865.2±10.37µs        ? ?/sec
smol-wiki-articles.csv: basic with quote/"spain"                                         1.01    542.0±5.12µs        ? ?/sec    1.00   537.0±11.04µs        ? ?/sec
smol-wiki-articles.csv: basic without quote/film                                         1.00    963.7±3.69µs        ? ?/sec    1.00    960.2±3.91µs        ? ?/sec
smol-wiki-articles.csv: basic without quote/france                                       1.00      7.2±0.02ms        ? ?/sec    1.00      7.2±0.03ms        ? ?/sec
smol-wiki-articles.csv: basic without quote/japan                                        1.00      4.2±0.02ms        ? ?/sec    1.00      4.2±0.02ms        ? ?/sec
smol-wiki-articles.csv: basic without quote/machine                                      1.00  1797.6±34.53µs        ? ?/sec    1.00  1792.6±19.03µs        ? ?/sec
smol-wiki-articles.csv: basic without quote/miles davis                                  1.00      4.7±0.02ms        ? ?/sec    1.00      4.7±0.02ms        ? ?/sec
smol-wiki-articles.csv: basic without quote/mingus                                       1.01    564.9±3.21µs        ? ?/sec    1.00    557.9±3.54µs        ? ?/sec
smol-wiki-articles.csv: basic without quote/rock and roll                                1.01   1812.7±8.35µs        ? ?/sec    1.00   1794.5±8.61µs        ? ?/sec
smol-wiki-articles.csv: basic without quote/spain                                        1.00      3.4±0.01ms        ? ?/sec    1.00      3.3±0.01ms        ? ?/sec
smol-wiki-articles.csv: prefix search/c                                                  1.01    811.3±2.93µs        ? ?/sec    1.00    804.9±3.90µs        ? ?/sec
smol-wiki-articles.csv: prefix search/g                                                  1.00  1021.4±11.12µs        ? ?/sec    1.00  1017.6±11.13µs        ? ?/sec
smol-wiki-articles.csv: prefix search/j                                                  1.00  1021.1±11.11µs        ? ?/sec    1.00   1018.3±7.53µs        ? ?/sec
smol-wiki-articles.csv: prefix search/q                                                  1.00    479.5±2.28µs        ? ?/sec    1.01    483.0±2.74µs        ? ?/sec
smol-wiki-articles.csv: prefix search/t                                                  1.00   1098.8±8.24µs        ? ?/sec    1.01   1104.5±7.61µs        ? ?/sec
smol-wiki-articles.csv: prefix search/x                                                  1.00  1833.3±11.75µs        ? ?/sec    1.00  1834.1±11.37µs        ? ?/sec
smol-wiki-articles.csv: proximity/april paris                                            1.00      4.9±0.02ms        ? ?/sec    1.00      4.9±0.02ms        ? ?/sec
smol-wiki-articles.csv: proximity/diesel engine                                          1.00    955.3±4.00µs        ? ?/sec    1.00    951.1±7.35µs        ? ?/sec
smol-wiki-articles.csv: proximity/herald sings                                           1.00      2.3±0.01ms        ? ?/sec    1.00      2.3±0.01ms        ? ?/sec
smol-wiki-articles.csv: proximity/tea two                                                1.02    232.9±1.94µs        ? ?/sec    1.00    228.1±2.10µs        ? ?/sec
smol-wiki-articles.csv: typo/Disnaylande                                                 1.00      2.3±0.01ms        ? ?/sec    1.00      2.3±0.01ms        ? ?/sec
smol-wiki-articles.csv: typo/aritmetric                                                  1.00      2.8±0.01ms        ? ?/sec    1.00      2.8±0.01ms        ? ?/sec
smol-wiki-articles.csv: typo/linax                                                       1.01    303.2±1.73µs        ? ?/sec    1.00    299.6±2.15µs        ? ?/sec
smol-wiki-articles.csv: typo/migrosoft                                                   1.00      2.4±0.01ms        ? ?/sec    1.01      2.4±0.01ms        ? ?/sec
smol-wiki-articles.csv: typo/nympalidea                                                  1.00  1880.3±13.00µs        ? ?/sec    1.00   1881.7±9.63µs        ? ?/sec
smol-wiki-articles.csv: typo/phytogropher                                                1.00      2.0±0.04ms        ? ?/sec    1.00      2.0±0.01ms        ? ?/sec
smol-wiki-articles.csv: typo/sisan                                                       1.00    464.8±2.73µs        ? ?/sec    1.00    466.2±2.84µs        ? ?/sec
smol-wiki-articles.csv: typo/the fronce                                                  1.02  1410.2±11.21µs        ? ?/sec    1.00  1388.5±32.99µs        ? ?/sec
smol-wiki-articles.csv: words/Abraham machin                                             1.00   909.1±10.47µs        ? ?/sec    1.00    906.7±3.85µs        ? ?/sec
smol-wiki-articles.csv: words/Idaho Bellevue pizza                                       1.00   1057.0±7.99µs        ? ?/sec    1.14   1201.3±7.18µs        ? ?/sec
smol-wiki-articles.csv: words/Kameya Tokujirō mingus monk                                1.00   1405.4±9.93µs        ? ?/sec    1.11   1563.3±7.63µs        ? ?/sec
smol-wiki-articles.csv: words/Ulrich Hensel meilisearch milli                            1.00      3.5±0.01ms        ? ?/sec    1.02      3.6±0.01ms        ? ?/sec
smol-wiki-articles.csv: words/the black saint and the sinner lady and the good doggo     1.01      2.9±0.01ms        ? ?/sec    1.00      2.9±0.01ms        ? ?/sec

@Kerollmops Kerollmops marked this pull request as draft November 27, 2023 10:00
@Kerollmops Kerollmops marked this pull request as ready for review November 28, 2023 09:11
milli/src/index.rs Outdated Show resolved Hide resolved
milli/src/index.rs Outdated Show resolved Hide resolved
milli/src/index.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Nov 28, 2023

@Kerollmops Kerollmops merged commit 6376c34 into main Nov 28, 2023
10 checks passed
@Kerollmops Kerollmops deleted the update-heed-0.20 branch November 28, 2023 14:29
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants