Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed payload limit setting being ignored for delete documents by batch #4231

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fixed payload limit setting being ignored for delete documents by batch #4231

merged 1 commit into from
Nov 27, 2023

Conversation

Karribalu
Copy link
Contributor

Pull Request

Related issue

Fixes #4224

What does this PR do?

  • Added http_payload_size_limit to JsonConfig to allow deleting documents in batches with a payload size greater than 2MB, which is the default limit set in the JsonConfig crate.

PR checklist

Please check if your PR fulfills the following requirements:

  • [Y] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [Y] Have you read the contributing guidelines?
  • [Y] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Kerollmops Kerollmops added this to the v1.6.0 milestone Nov 27, 2023
@Kerollmops Kerollmops added the bug Something isn't working as expected label Nov 27, 2023
Kerollmops
Kerollmops approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes! Simple and working 👌
bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2023

Build succeeded:

@Karribalu Karribalu closed this Nov 27, 2023
@meili-bors meili-bors bot merged commit 3d23b38 into meilisearch:main Nov 27, 2023
10 checks passed
@curquiza curquiza mentioned this pull request Jan 10, 2024
Closed
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

The delete documents by batch route ignores the payload limit setting
3 participants
@Karribalu @Kerollmops @meili-bot