Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task queue webhook #4238

Merged
merged 12 commits into from
Dec 21, 2023
Merged

Task queue webhook #4238

merged 12 commits into from
Dec 21, 2023

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Nov 28, 2023

Prototype prototype-task-queue-webhook-1

The prototype is available through Docker by using the following command:

docker run -p 7700:7700 -v $(pwd)/meili_data:/meili_data getmeili/meilisearch:prototype-task-queue-webhook-1

Pull Request

Implements the task queue webhook.

Related issue

Fixes #4236

What does this PR do?

  • Provide a new cli and env var for the webhook, respectively called --task-webhook-url and MEILI_TASK_WEBHOOK_URL
  • Also supports sending the requests with a custom Authorization header by specifying the optional --task-webhook-authorization-header CLI parameter or MEILI_TASK_WEBHOOK_AUTHORIZATION_HEADER env variable.
  • Throw an error if the specified URL is invalid
  • Every time a batch is processed, send all the finished tasks into the webhook with our public TaskView type as a JSON Line GZIPed body.
  • Add one test.

PR checklist

Before becoming ready to review

  • Add a test
  • Compress the data we send
  • Chunk and stream the data we send
  • Remove the unwrap in the index-scheduler when sending the data fails
  • The analytics are missing

Before merging

  • Release a prototype

@irevoire irevoire added this to the v1.6.0 milestone Dec 4, 2023
@irevoire irevoire added enhancement New feature or improvement prototype available You can test this feature using the available prototype labels Dec 4, 2023
@Kerollmops Kerollmops changed the base branch from main to release-v1.6.0 December 21, 2023 00:12
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@dureuill dureuill marked this pull request as ready for review December 21, 2023 14:43
Copy link
Contributor

meili-bors bot commented Dec 21, 2023

@meili-bors meili-bors bot merged commit 43e822e into release-v1.6.0 Dec 21, 2023
11 checks passed
@meili-bors meili-bors bot deleted the task-queue-webhook branch December 21, 2023 15:36
@curquiza curquiza mentioned this pull request Jan 4, 2024
3 tasks
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement prototype available You can test this feature using the available prototype v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task Queue Webhook
4 participants