Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation warnings on main #4295

Merged
merged 1 commit into from Jan 2, 2024
Merged

fix compilation warnings on main #4295

merged 1 commit into from Jan 2, 2024

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Jan 2, 2024 •
edited

Pull Request

Related issue

Fixes #4292

What does this PR do?

  • Removed unused imports

#4294 fixes the issue for the release v1.6

@irevoire irevoire added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 2, 2024
@irevoire irevoire added this to the v1.7.0 milestone Jan 2, 2024
@irevoire irevoire requested a review from curquiza January 2, 2024 14:41
@irevoire irevoire mentioned this pull request Jan 2, 2024
Merged
@irevoire irevoire changed the title fix warning on main fix compilation warnings on main Jan 2, 2024
meili-bors bot added a commit that referenced this pull request Jan 2, 2024
@meili-bors @irevoire
Merge #4294
da99a04 
4294: fix compilation warnings for release v1.6 r=curquiza a=irevoire

# Pull Request

## Related issue
Fixes #4292

## What does this PR do?
- Removed unused imports

#4295 fixes the issue no main

Co-authored-by: Tamo <tamo@meilisearch.com>
curquiza
curquiza approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 2, 2024

Build succeeded!

And happy new year! 🎉

@meili-bors meili-bors bot merged commit c4bb435 into main Jan 2, 2024
10 checks passed
@meili-bors meili-bors bot deleted the fix-warning branch January 2, 2024 16:01
@meili-bot meili-bot added the v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11 label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Basic CI failing, preventing us from merging anything
3 participants
@irevoire @curquiza @meili-bot