Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of values returned by the facet search #4311

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Limit the number of values returned by the facet search #4311

merged 1 commit into from
Jan 10, 2024

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Jan 10, 2024 •
edited
Loading

This PR fixes a bug where the number of values per facet returned by the indexes/{index}/facet-search route was not tacking the faceting.maxValuePerFacet setting. It also adds a test.

Fixes #4312

@Kerollmops Kerollmops added bug Something isn't working as expected impacts docs This issue involves changes in the Meilisearch's documentation labels Jan 10, 2024
@Kerollmops Kerollmops added this to the v1.6.0 milestone Jan 10, 2024
dureuill
dureuill reviewed Jan 10, 2024
View reviewed changes
milli/src/search/mod.rs Outdated Show resolved Hide resolved
dureuill
dureuill reviewed Jan 10, 2024
View reviewed changes
milli/src/search/mod.rs Outdated Show resolved Hide resolved
@curquiza curquiza modified the milestones: v1.6.0, v1.7.0 Jan 10, 2024
@curquiza
Copy link
Member

To let you know: I changed the milestones since this PR will be merged into main

@curquiza curquiza removed the impacts docs This issue involves changes in the Meilisearch's documentation label Jan 10, 2024
@Kerollmops Kerollmops force-pushed the limit-values-facet-search branch 2 times, most recently from a6bdf7d to b77b464 Compare January 10, 2024 15:52
@Kerollmops Kerollmops changed the base branch from main to release-v1.6.0 January 10, 2024 15:52
@Kerollmops Kerollmops modified the milestones: v1.7.0, v1.6.0 Jan 10, 2024
@Kerollmops
Copy link
Member Author

@curquiza, that's my bad. I rebased on the release-v1.6 as I would like to fix this bug for Monday (it's a request of one of our customers).

Thank you @dureuill for your review 🙏

dureuill
dureuill approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dureuill
Copy link
Contributor

bors merge

@curquiza curquiza linked an issue Jan 10, 2024 that may be closed by this pull request
The /facet-search route doesn't take the faceting.maxValuesPerFacet setting #4312
Closed
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 10, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 1f5e8fc into release-v1.6.0 Jan 10, 2024
10 checks passed
@meili-bors meili-bors bot deleted the limit-values-facet-search branch January 10, 2024 16:46
@curquiza curquiza mentioned this pull request Jan 10, 2024
Closed
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

The /facet-search route doesn't take the faceting.maxValuesPerFacet setting
4 participants
@Kerollmops @curquiza @dureuill @meili-bot