Add job variable to grafana dashboard #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meilisearch job_name was hardcoded in the dashboard config so if user sets anything but meilisearch as job_name on prometheus side the dashboard does not work see: https://github.com/orgs/meilisearch/discussions/625#discussioncomment-8143282
irevoire
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
I tested it, and it works and seems more versatile than what we have.
It's not breaking and doesn't impact the associated product discussion 👌
Thanks for your contribution @capJavert that's perfect I'm merging!
bors merge
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
irevoire
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes https://github.com/orgs/meilisearch/discussions/625#discussioncomment-8143282
What does this PR do?
"meilisearch" as job_name was hardcoded in the dashboard config so if user sets anything but "meilisearch" as job_name on prometheus side the dashboard does not work.
With this change dasboard will auto load the values from data source (much like instance variable) and show the correct data. This now also adds support for multiple meilisearch jobs in single dashboard.
See: https://github.com/orgs/meilisearch/discussions/625#discussioncomment-8143282
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!