Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rustls to 0.21.10 and ring to 0.17 #4400

Merged
merged 1 commit into from Feb 12, 2024

Conversation

hack3ric
Copy link
Contributor

Pull Request

What does this PR do?

  • Upgrade dependencies that uses ring 0.16 so that they rely on ring 0.17 instead
  • Use rustls 0.21 for actix-{http,tls}, since newer versions of rustls uses ring 0.17
  • Fix some trivial breaking API changes caused by above

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza
Copy link
Member

Just tested with our Docker CI, it works 👌
https://github.com/meilisearch/meilisearch/actions/runs/7870699560/job/21472452820

@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Feb 12, 2024
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I was unable to do so in my recent bump dependencies PR #4332 but it seems you found the secret bind_rustls_021 method 🎉

bors merge

Copy link
Contributor

meili-bors bot commented Feb 12, 2024

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@curquiza curquiza added this to the v1.8.0 milestone Feb 12, 2024
@curquiza
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Feb 12, 2024

@meili-bors meili-bors bot merged commit 82b43e9 into meilisearch:main Feb 12, 2024
11 checks passed
@hack3ric hack3ric deleted the upgrade-ring branch February 12, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants