Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance facet incremental #4433

Merged
merged 4 commits into from Feb 28, 2024
Merged

Conversation

ManyTheFish
Copy link
Member

Pull Request

Related issue

Fixes #4367
Fixes #4409

What does this PR do?

@ManyTheFish
Copy link
Member Author

/benchmark indexing

@meili-bot
Copy link
Contributor

Here are your indexing benchmarks diff 👊

group                                                                     indexing_enhance-facet-incremental_12f5389b    indexing_main_15dafde2
-----                                                                     -------------------------------------------    ----------------------
indexing/-geo-delete-facetedNumber-facetedGeo-searchable-                 1.00       6.2±0.13s        ? ?/sec            1.02       6.3±0.14s        ? ?/sec
indexing/-movies-delete-facetedString-facetedNumber-searchable-           1.34  1597.7±44.69ms        ? ?/sec            1.00  1188.7±17.96ms        ? ?/sec
indexing/-movies-delete-facetedString-facetedNumber-searchable-nested-    1.00       3.7±0.02s        ? ?/sec            1.88       7.0±0.16s        ? ?/sec
indexing/-songs-delete-facetedString-facetedNumber-searchable-            1.00       6.0±0.19s        ? ?/sec            1.69      10.2±0.30s        ? ?/sec
indexing/-wiki-delete-searchable-                                         1.10      26.7±0.70s        ? ?/sec            1.00      24.2±0.93s        ? ?/sec
indexing/Indexing geo_point                                               1.21      57.3±0.86s        ? ?/sec            1.00      47.5±0.67s        ? ?/sec
indexing/Indexing movies in three batches                                 1.00       3.5±0.08s        ? ?/sec            1.01       3.6±0.11s        ? ?/sec
indexing/Indexing movies with default settings                            1.09       3.8±0.09s        ? ?/sec            1.00       3.5±0.06s        ? ?/sec
indexing/Indexing nested movies with default settings                     1.45       6.5±0.07s        ? ?/sec            1.00       4.5±0.06s        ? ?/sec
indexing/Indexing nested movies without any facets                        1.24       5.0±0.15s        ? ?/sec            1.00       4.0±0.15s        ? ?/sec
indexing/Indexing songs in three batches with default settings            1.26      34.1±0.24s        ? ?/sec            1.00      27.0±0.37s        ? ?/sec
indexing/Indexing songs with default settings                             1.32      43.0±0.38s        ? ?/sec            1.00      32.5±0.99s        ? ?/sec
indexing/Indexing songs without any facets                                1.20      36.3±1.35s        ? ?/sec            1.00      30.3±0.81s        ? ?/sec
indexing/Indexing songs without faceted numbers                           1.27      40.5±0.16s        ? ?/sec            1.00      32.0±0.83s        ? ?/sec
indexing/Indexing wiki                                                    1.05     277.4±2.28s        ? ?/sec            1.00     264.4±5.99s        ? ?/sec
indexing/Indexing wiki in three batches                                   1.02     212.4±7.08s        ? ?/sec            1.00     208.2±2.28s        ? ?/sec
indexing/Reindexing geo_point                                             1.03      12.6±0.04s        ? ?/sec            1.00      12.3±0.05s        ? ?/sec
indexing/Reindexing movies with default settings                          1.06   229.3±29.50ms        ? ?/sec            1.00   215.5±30.49ms        ? ?/sec
indexing/Reindexing songs with default settings                           1.03       3.6±0.05s        ? ?/sec            1.00       3.5±0.05s        ? ?/sec
indexing/Reindexing wiki                                                  1.00     338.4±7.47s        ? ?/sec            1.11     374.0±5.63s        ? ?/sec

@curquiza curquiza added this to the v1.7.0 milestone Feb 22, 2024
milli/src/update/facet/incremental.rs Outdated Show resolved Hide resolved
milli/src/update/facet/incremental.rs Show resolved Hide resolved
milli/src/update/facet/incremental.rs Outdated Show resolved Hide resolved
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very good!
bors merge

Copy link
Contributor

meili-bors bot commented Feb 28, 2024

@meili-bors meili-bors bot merged commit b87485e into release-v1.7.0 Feb 28, 2024
10 checks passed
@meili-bors meili-bors bot deleted the enhance-facet-incremental branch February 28, 2024 16:10
@meili-bot meili-bot added the v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11 label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11
Projects
None yet
4 participants