Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix milli link in contributing doc #4499

Merged
merged 2 commits into from Mar 18, 2024
Merged

Fix milli link in contributing doc #4499

merged 2 commits into from Mar 18, 2024

Conversation

mohsen-alizadeh
Copy link
Contributor

@mohsen-alizadeh mohsen-alizadeh commented Mar 18, 2024 •
edited

Pull Request

Related issue

Fixes #4498

What does this PR do?

The milli link in CONTRIBUTING.md targeted the archived milli repository. it has to be changed to target to the milli crate in the main repo

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza requested a review from a team March 18, 2024 09:17
curquiza
curquiza reviewed Mar 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@curquiza curquiza requested a review from a team March 18, 2024 13:20
@curquiza curquiza added the documentation Related to the documentation of this repository label Mar 18, 2024
@curquiza curquiza added this to the v1.8.0 milestone Mar 18, 2024
@curquiza @Kerollmops
Update CONTRIBUTING.md
f4037c1 
Co-authored-by: Clément Renault <renault.cle@gmail.com>
curquiza
curquiza approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Mar 18, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 2984047 into meilisearch:main Mar 18, 2024
10 checks passed
@meili-bot meili-bot added the v1.8.0 PRs/issues solved in v1.8.0 released on 2024-05-06 label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops left review comments

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
documentation Related to the documentation of this repository v1.8.0 PRs/issues solved in v1.8.0 released on 2024-05-06
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

The milli link in CONTRIBUTING.md targeted the archived milli repository.
4 participants
@mohsen-alizadeh @Kerollmops @curquiza @meili-bot