Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest embedder #4509

Merged
merged 9 commits into from Mar 27, 2024
Merged

Rest embedder #4509

merged 9 commits into from Mar 27, 2024

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Mar 19, 2024 •
edited

Fixes #4531

See Usage page

Implementation changes

  • Remove tokio, futures, reqwests
  • Add a new milli::vector::rest::Embedder embedder
  • Update OpenAI and Ollama embedders to use the REST embedder internally
  • Make Embedder::embed a sync method
  • Add the new embedder source as described in the usage

@dureuill dureuill added this to the v1.8.0 milestone Mar 19, 2024
@dureuill dureuill mentioned this pull request Mar 25, 2024
Closed
8 tasks
@dureuill dureuill marked this pull request as ready for review March 25, 2024 09:35
@dureuill dureuill mentioned this pull request Mar 25, 2024
Merged
@dureuill dureuill mentioned this pull request Mar 26, 2024
Merged
ManyTheFish
ManyTheFish approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Mar 27, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 34dfea7 into main Mar 27, 2024
10 checks passed
@meili-bors meili-bors bot deleted the rest_embedder branch March 27, 2024 10:09
@meili-bot meili-bot added the v1.8.0 PRs/issues solved in v1.8.0 released on 2024-05-06 label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
v1.8.0 PRs/issues solved in v1.8.0 released on 2024-05-06
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Add a generic REST embedder
3 participants
@dureuill @ManyTheFish @meili-bot