Repository navigation
Rest embedder - #4509
Merged
Merged
Rest embedder#4509
Conversation
Contributor
salmanarshad321
pushed a commit
to salmanarshad321/meilisearch
that referenced
this pull request
Sep 23, 2026
4509: Rest embedder r=ManyTheFish a=dureuill Fixes meilisearch#4531 See [Usage page](https://meilisearch.notion.site/v1-8-AI-search-API-usage-135552d6e85a4a52bc7109be82aeca42?pvs=25#e6f58c3b742c4effb4ddc625ce12ee16) ### Implementation changes - Remove tokio, futures, reqwests - Add a new `milli::vector::rest::Embedder` embedder - Update OpenAI and Ollama embedders to use the REST embedder internally - Make Embedder::embed a sync method - Add the new embedder source as described in the usage Co-authored-by: Louis Dureuil <louis@meilisearch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4531
See Usage page
Implementation changes
milli::vector::rest::Embedderembedder