Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the http request duration histogram bucket boundaries to follow the opentelemetry spec #4530

Merged
merged 1 commit into from Mar 25, 2024
Merged

Fixes the http request duration histogram bucket boundaries to follow the opentelemetry spec #4530

merged 1 commit into from Mar 25, 2024

Conversation

rohankmr414
Copy link
Contributor

Pull Request

What does this PR do?

  • Fixes the http request duration histogram bucket boundaries to follow the opentelemetry spec, currently the bucket boundaries are too granular and only track latencies below 1s.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@rohankmr414
Copy link
Contributor Author

More details here -> https://github.com/orgs/meilisearch/discussions/625#discussioncomment-8897790

@rohankmr414 rohankmr414 changed the title fix: set the histogram bucket boundaries following the otel spec fix: set the histogram bucket boundaries to follow the otel spec Mar 25, 2024
@rohankmr414 rohankmr414 force-pushed the prometheus-historgram-bucket-fix branch from 36ef07f to 13a84ae Compare March 25, 2024 05:50
irevoire
irevoire approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, yeah good idea thanks!

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Mar 25, 2024

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@irevoire irevoire added this to the v1.8.0 milestone Mar 25, 2024
@irevoire irevoire added the experimental feature Related to an experimental feature label Mar 25, 2024
@curquiza
Copy link
Member

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Mar 25, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 5ea017b into meilisearch:main Mar 25, 2024
2 checks passed
@curquiza curquiza added the bug Something isn't working as expected label Mar 29, 2024
@curquiza curquiza changed the title fix: set the histogram bucket boundaries to follow the otel spec Fixes the http request duration histogram bucket boundaries to follow the opentelemetry spec Mar 29, 2024
@rohankmr414 rohankmr414 deleted the prometheus-historgram-bucket-fix branch March 31, 2024 11:18
@meili-bot meili-bot added the v1.8.0 PRs/issues solved in v1.8.0 released on 2024-05-06 label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected experimental feature Related to an experimental feature v1.8.0 PRs/issues solved in v1.8.0 released on 2024-05-06
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rohankmr414 @curquiza @irevoire @meili-bot