Stream documents #4544
Merged
Stream documents #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
performance
irevoire
force-pushed
the
stream-documents
branch
from
993f62b
to
0eedbad
Compare
irevoire
force-pushed
the
stream-documents
branch
from
0eedbad
to
2279ce7
Compare
irevoire
force-pushed
the
stream-documents
branch
from
270413a
to
f31b816
Compare
irevoire
force-pushed
the
stream-documents
branch
from
f31b816
to
273c6e8
Compare
|
Build failed: |
|
bors merge |
irevoire
added
the
breaking change
|
Reverting this PR since we realized it was actually introducing an unexpected breaking change in meilisearch sorry |
meili-bors bot
added a commit
that referenced
this pull request
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=Kerollmops a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this pull request
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this pull request
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=irevoire a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this pull request
May 20, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this pull request
May 21, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=curquiza a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot
added a commit
that referenced
this pull request
May 21, 2024
4644: Revert "Stream documents" and keep heed+arroy to the latest verion r=Kerollmops a=irevoire Reverts #4544 Fixes #4641 I didn’t realize that some http clients were not handling chunked http requests like you would expect (if you ask the body, it gives you the body), which made the previous PR breaking. There is no way to provide a good fix to the issue we initially wanted to fix without breaking meilisearch and that’s not planned for now. Co-authored-by: Tamo <irevoire@protonmail.ch> Co-authored-by: Tamo <tamo@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #4383
Perf
2M hackernews:
main:
Time to retrieve: 7s
RAM consumption: 2+GiB
stream:
Time to retrieve: 4.7s
RAM consumption: Too small