Change tide to actix-web #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdequele
force-pushed
the
tide-to-actix-web
branch
from
e5ed736
to
36272f9
Compare
qdequele
force-pushed
the
tide-to-actix-web
branch
8 times, most recently
from
22df639
to
9d30f9e
Compare
MarinPostma
reviewed
Apr 19, 2020
qdequele
force-pushed
the
tide-to-actix-web
branch
from
7da0263
to
6aceef1
Compare
qdequele
force-pushed
the
tide-to-actix-web
branch
from
04df931
to
8c30ea8
Compare
MarinPostma
reviewed
Apr 22, 2020
Kerollmops
requested changes
Apr 24, 2020
qdequele
force-pushed
the
tide-to-actix-web
branch
2 times, most recently
from
7bfaa60
to
27ae401
Compare
Kerollmops
requested changes
Apr 24, 2020
There was a problem hiding this comment.
BTW do we have beautiful serde error messages when the input JSON objects are wrong now?
I confirm that the code is much better and easier to read therefore easier to maintain, even the wrap thing that you made you guys (@qdequele and @MarinPostma) is awesome! Good Job!
qdequele
force-pushed
the
tide-to-actix-web
branch
2 times, most recently
from
93ba8dd
to
5cbadb4
Compare
Kerollmops
requested changes
Apr 27, 2020
Kerollmops
requested changes
Apr 28, 2020
add settings endpoint; wip
fix requested changes
qdequele
force-pushed
the
tide-to-actix-web
branch
from
5cbadb4
to
99866ba
Compare
|
@Kerollmops done. |
|
So we are now on actix-web, congratulation 🎉 |
erlend-sh
added a commit
to erlend-sh/examples
that referenced
this pull request
Apr 29, 2020
MeiliSearch very recently migrated from Tide to actix-web: meilisearch/meilisearch#601
19 tasks
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
601: Introduce snapshot tests r=Kerollmops a=loiclec # Pull Request ## What does this PR do? Introduce snapshot tests into milli, by using the `insta` crate. This implements the idea described by #597 See: [insta.rs](https://insta.rs) ## Design There is now a new file, `snapshot_tests.rs`, which is compiled only under `#[cfg(test)]`. It exposes the `db_snap!` macro, which is used to snapshot the content of a database. When running `cargo test`, `insta` will check that the value of the current snapshot is the same as the previous one (on the file system). If they are the same, the test passes. If they are different, the test fails and you are asked to review the new snapshot to approve or reject it. We don't want to save very large snapshots to the file system, because it will pollute the git repository and increase its size too much. Instead, we only save their `md5` hashes under the name `<snapshot_name>.hash.snap`. There is a new environment variable called `MILLI_TEST_FULL_SNAPS` which can be set to `true` in order to *also* save the full content of the snapshot under the name `<snapshot_name>.full.snap`. However, snapshots with the extension `.full.snap` are never saved to the git repository. ## Example ```rust // In e.g. facets.rs #[test] fn my_test() { // create an index let index = TempIndex::new(): index.add_documents(...); index.update_settings(|settings| ...); // then snapshot the content of one of its databases // the snapshot will be saved at the current folder under facets.rs/my_test/facet_id_string_docids.snap db_snap!(index, facet_id_string_docids); index.add_documents(...); // we can also name the snapshot to ensure there is no conflict // this snapshot will be saved at facets.rs/my_test/updated/facet_id_string_docids.snap db_snap!(index, facet_id_string, docids, "updated"); // and we can also use "inline" snapshots, which insert their content in the given string literal db_snap!(index, field_distributions, `@"");` // once the snapshot is approved, it will automatically get transformed to, e.g.: // db_snap!(index, field_distributions, `@"` // my_facet 21 // other_field 3 // "); // now let's add **many** documents index.add_documents(...); // because the snapshot is too big, its hash is saved instead // if the MILLI_TEST_FULL_SNAPS env variable is set to true, then the full snapshot will also be saved // at facets.rs/my_test/large/facet_id_string_docids.full.snap db_snap!(index, facet_id_string_docids, "large", `@"5348bbc46b5384455b6a900666d2a502");` } ``` Co-authored-by: Loïc Lecrenier <loic@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Out of scope work done:
Before review:
unwrap().clone()index.document()to the older code