Facet count #676
Merged
Facet count #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
requested changes
May 12, 2020
Kerollmops
requested changes
May 12, 2020
Kerollmops
requested changes
May 13, 2020
Kerollmops
requested changes
May 13, 2020
Kerollmops
approved these changes
May 13, 2020
19 tasks
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
676: chore: added `IN`,`NOT IN` to `invalid_filter` msg r=irevoire a=Pranav-yadav # Pull Request ## Related issue `Fixes` #3004 ## What does this PR do? - Improves correct error msg in response ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Pranav Yadav <Pranavyadav3912@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
677: run the tests in all workspaces r=curquiza a=irevoire With #676 I noticed the tests were not running in any of our sub crates. Most of our sub crates didn't includes any tests though. But the filter-parser did and we're lucky we never broke these one without noticing 😁 Co-authored-by: Irevoire <tamo@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#625