New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight align fix #679

Merged

Kerollmops merged 4 commits into meilisearch:master from MarinPostma:highlight-align-fix

May 14, 2020

Contributor

MarinPostma commented May 13, 2020

closes #637

MarinPostma force-pushed the highlight-align-fix branch 2 times, most recently from b16bcbd to 32e9b87 Compare

May 13, 2020 16:48

Kerollmops reviewed

View reviewed changes

meilisearch-http/src/helpers/meilisearch.rs Outdated Show resolved Hide resolved

MarinPostma force-pushed the highlight-align-fix branch from 32e9b87 to 0190f42 Compare

May 14, 2020 08:10

MarinPostma marked this pull request as ready for review

May 14, 2020 09:02

MarinPostma force-pushed the highlight-align-fix branch from 831cd3e to 98d4dca Compare

May 14, 2020 09:30

MarinPostma requested a review from Kerollmops

May 14, 2020 09:30

Kerollmops requested changes

View reviewed changes

Member

Kerollmops left a comment

Can you add a test with the not working documents of the user who find this bug, please?

CHANGELOG.md Outdated Show resolved Hide resolved

MarinPostma force-pushed the highlight-align-fix branch 3 times, most recently from 7a9c305 to a0e3417 Compare

May 14, 2020 10:53

MarinPostma requested a review from Kerollmops

May 14, 2020 10:54

MarinPostma force-pushed the highlight-align-fix branch from a0e3417 to acdb731 Compare

May 14, 2020 10:54

MarinPostma added 4 commits

May 14, 2020 12:56


          remove unnecessary clone

ce78968


          fix unaligned highlight

a94ee16


          update changelog

54707e4


          add tests

9c1de3a

MarinPostma force-pushed the highlight-align-fix branch from acdb731 to 9c1de3a Compare

May 14, 2020 10:58

Kerollmops approved these changes

View reviewed changes

Kerollmops merged commit e2b71b0 into meilisearch:master

bidoubiwa mentioned this pull request

Prepare documentation for v.0.11 of MeiliSearch meilisearch/documentation#379

Merged

19 tasks

bors bot added a commit that referenced this pull request


          Merge #679

1a1ad8a

679: Bump Swatinem/rust-cache from 2.0.0 to 2.0.1 r=curquiza a=dependabot[bot]

Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache) from 2.0.0 to 2.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/releases">Swatinem/rust-cache's releases</a>.</em></p>
<blockquote>
<h2>v2.0.1</h2>
<ul>
<li>Primarily just updating dependencies to fix GitHub deprecation notices.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md">Swatinem/rust-cache's changelog</a>.</em></p>
<blockquote>
<h2>2.0.1</h2>
<ul>
<li>Primarily just updating dependencies to fix GitHub deprecation notices.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/Swatinem/rust-cache/commit/22c9328bcba27aa81a32b1bef27c7e3c78052531"><code>22c9328</code></a> 2.0.1</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/d4d463bd9b10ee86a7deffecaa831cb35929497d"><code>d4d463b</code></a> bump deps and rebuild</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/c4652c677cd7ae474201faf9d7b80a93eae1251d"><code>c4652c6</code></a> Update <code>`@actions/core</code>` (<a href="https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/83">#83</a>)</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/76686c56f2b581d1bb5bda44b51f7e24bd9b8b8e"><code>76686c5</code></a> docs: Fix github workflows directory (<a href="https://github-redirect.dependabot.com/Swatinem/rust-cache/issues/79">#79</a>)</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/1b43d2f2c3b0c4952d984d95049b6e16d9255701"><code>1b43d2f</code></a> remove outdated versioning note</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/20b9201e8a1756c7bb25ce1e242e7d8d037bb604"><code>20b9201</code></a> bump cargo hash</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/0d72e5f9a02a9fcd450565bf61f2a10c404b754c"><code>0d72e5f</code></a> revert explicit dir close</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/86531941c27fbf343b3c0a2699a847faf962fe7e"><code>8653194</code></a> Merge branch 'master' of <a href="https://github.com/Swatinem/rust-cache">https://github.com/Swatinem/rust-cache</a></li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/be4be3720d8e98388759f580b2e3a06283b579c7"><code>be4be37</code></a> explicitly close dir handles, add more logging, cleanups</li>
<li><a href="https://github.com/Swatinem/rust-cache/commit/213334cd989f8501ef7f6f317ca79bb481420578"><code>213334c</code></a> cargo update</li>
<li>Additional commits viewable in <a href="https://github.com/Swatinem/rust-cache/compare/v2.0.0...v2.0.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Swatinem/rust-cache&package-manager=github_actions&previous-version=2.0.0&new-version=2.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment