Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation + bug fix on typo-tolerance #519

Merged
merged 6 commits into from May 3, 2022

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Apr 28, 2022

I cherry-picked the commits from these PRs

release-v0.26.4 has been started from the tag v0.26.3 and not from main

The release tag v0.26.4 will be done on the branch release-v0.26.4 once this PR is merge

@curquiza curquiza added the no breaking The related changes are not breaking (DB nor API) label Apr 28, 2022
@curquiza curquiza marked this pull request as draft April 28, 2022 19:55
@curquiza
Copy link
Member Author

Don't merge it until we take a decision if this should be fixed or not: meilisearch/meilisearch#2358

@curquiza curquiza changed the title Release v0.26.4: returns facets even when there is no value associated to it Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation May 3, 2022
@curquiza curquiza marked this pull request as ready for review May 3, 2022 14:00
@curquiza
Copy link
Member Author

curquiza commented May 3, 2022

bors try

bors bot added a commit that referenced this pull request May 3, 2022
@bors
Copy link
Contributor

bors bot commented May 3, 2022

@curquiza
Copy link
Member Author

curquiza commented May 3, 2022

bors merge

bors bot added a commit that referenced this pull request May 3, 2022
519: Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation r=curquiza a=curquiza

I cherry-picked the commits from these PRs
- #518
- #522

`release-v0.26.4` has been started from the tag `v0.26.3` and not from main

The release tag `v0.26.4` will be done on the branch `release-v0.26.4` once this PR is merge

Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@curquiza
Copy link
Member Author

curquiza commented May 3, 2022

bors merge-

@bors
Copy link
Contributor

bors bot commented May 3, 2022

Canceled.

@curquiza
Copy link
Member Author

curquiza commented May 3, 2022

Still missing #520 to be put into this PR, sorry

@curquiza curquiza changed the title Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation + bug fix on typo-tolerance May 3, 2022
@curquiza
Copy link
Member Author

curquiza commented May 3, 2022

bors try

bors bot added a commit that referenced this pull request May 3, 2022
@bors
Copy link
Contributor

bors bot commented May 3, 2022

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented May 3, 2022

@bors bors bot merged commit 6ee67df into release-v0.26.4 May 3, 2022
@bors bors bot deleted the fix-facets branch May 3, 2022 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants