This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Return facets even when there is no value associated to it #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
added
the
no breaking
|
I will let @curquiza decide on whether we merge it now/here or not. |
|
What would be the issue to merge it @Kerollmops? |
|
Thank you, I merge this! |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
May 3, 2022
519: Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation r=curquiza a=curquiza I cherry-picked the commits from these PRs - #518 - #522 `release-v0.26.4` has been started from the tag `v0.26.3` and not from main The release tag `v0.26.4` will be done on the branch `release-v0.26.4` once this PR is merge Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
May 3, 2022
519: Release v0.26.4: returns facets even when there is no value associated to it + bug fix during indexation + bug fix on typo-tolerance r=Kerollmops a=curquiza I cherry-picked the commits from these PRs - #518 - #522 - #520 `release-v0.26.4` has been started from the tag `v0.26.3` and not from main The release tag `v0.26.4` will be done on the branch `release-v0.26.4` once this PR is merge Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: ad hoc <postma.marin@protonmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to meilisearch/meilisearch#2352 and should fix the issue when Meilisearch is up-to-date with this PR.