This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
fix phrase search #442
Merged
fix phrase search #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
fix-phrase-search
branch
2 times, most recently
from
8522f7b
to
4bb8ff3
Compare
MarinPostma
force-pushed
the
fix-phrase-search
branch
from
4bb8ff3
to
d852dc0
Compare
ManyTheFish
suggested changes
Feb 2, 2022
MarinPostma
force-pushed
the
fix-phrase-search
branch
from
55b8e0e
to
e215e8e
Compare
Kerollmops
suggested changes
Feb 3, 2022
MarinPostma
force-pushed
the
fix-phrase-search
branch
from
e215e8e
to
13de251
Compare
Kerollmops
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Looks good to me, waiting for the @ManyTheFish review before merging!
ManyTheFish
approved these changes
Feb 5, 2022
|
bors merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the exact match search on 7 words windows instead of only two. This makes false positive very very unlikely, and impossible on phrase query that are less than seven words.