Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

allow null values in csv #445

Merged
merged 1 commit into from
Feb 3, 2022
Merged

allow null values in csv #445

merged 1 commit into from
Feb 3, 2022

Conversation

MarinPostma
Copy link
Contributor

@MarinPostma MarinPostma commented Feb 3, 2022 •
edited

This pr allows null values in csv:

  • if the field is of type string, then an empty field is considered null (,,), anything other is turned into a string (i.e , , is a single whitespace string)
  • if the field is of type number, when the trimmed field is empty, we consider the value null (i.e ,,, , , are both null numbers) otherwise we try to parse the number.

@MarinPostma MarinPostma mentioned this pull request Feb 3, 2022
Closed
Kerollmops
Kerollmops suggested changes Feb 3, 2022
View reviewed changes
milli/src/documents/builder.rs Outdated Show resolved Hide resolved
Kerollmops
Kerollmops approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
bors merge

@gmourier
Copy link
Member

gmourier commented Feb 3, 2022

Thanks, @MarinPostma!

@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

Build succeeded:

@bors bors bot merged commit 267d14c into main Feb 3, 2022
@bors bors bot deleted the allow-null-csv-entries branch February 3, 2022 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarinPostma @gmourier @Kerollmops