This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
fix distinct count bug #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
fix-distinct-count-bug
branch
2 times, most recently
from
37cafbc
to
7b15a00
Compare
|
#490 should be merged before this PR since a new check is |
ManyTheFish
previously approved these changes
Apr 11, 2022
bors bot
added a commit
that referenced
this pull request
Apr 11, 2022
489: fix distinct count bug r=ManyTheFish a=MarinPostma fix meilisearch/meilisearch#2152 I think the issue was that we didn't take off the excluded candidates from the initial candidates when returning the candidates with the search result. Co-authored-by: ad hoc <postma.marin@protonmail.com>
ManyTheFish
added
the
no breaking
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Required status check \"Specify breaking\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 11, 2022
489: fix distinct count bug r=curquiza a=MarinPostma fix meilisearch/meilisearch#2152 I think the issue was that we didn't take off the excluded candidates from the initial candidates when returning the candidates with the search result. Co-authored-by: ad hoc <postma.marin@protonmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Required status check \"Specify breaking\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
curquiza
added
no breaking
|
This PR #492 should fix the bors issue |
curquiza
force-pushed
the
fix-distinct-count-bug
branch
from
7b15a00
to
c56b053
Compare
curquiza
previously approved these changes
Apr 11, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 11, 2022
489: fix distinct count bug r=curquiza a=MarinPostma fix meilisearch/meilisearch#2152 I think the issue was that we didn't take off the excluded candidates from the initial candidates when returning the candidates with the search result. Co-authored-by: ad hoc <postma.marin@protonmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Required status check \"Specify breaking\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors bot
added a commit
that referenced
this pull request
Apr 11, 2022
492: Add the new `Specify breaking` check to bors.toml r=MarinPostma a=curquiza Should prevent this problem: #489 (comment) Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Apr 12, 2022
492: Add the new `Specify breaking` check to bors.toml r=curquiza a=curquiza Should prevent this problem: #489 (comment) Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
|
bors merge- |
bors bot
added a commit
that referenced
this pull request
Apr 12, 2022
492: Add the new `Specify breaking` check to bors.toml r=curquiza a=curquiza Should prevent this problem: #489 (comment) Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Apr 12, 2022
492: Add the new `Specify breaking` check to bors.toml r=curquiza a=curquiza Should prevent this problem: #489 (comment) Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
curquiza
force-pushed
the
fix-distinct-count-bug
branch
from
c56b053
to
95a4ae2
Compare
bors bot
added a commit
that referenced
this pull request
Apr 13, 2022
492: Add the new `Specify breaking` check to bors.toml r=curquiza a=curquiza Should prevent this problem: #489 (comment) Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
curquiza
force-pushed
the
fix-distinct-count-bug
branch
from
95a4ae2
to
dda28d7
Compare
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
|
Already running a review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix meilisearch/meilisearch#2152
I think the issue was that we didn't take off the excluded candidates from the initial candidates when returning the candidates with the search result.