This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
fix min-word-len-for-typo not reset properly #499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
fix-min-word-len-typo-not-resetting
branch
2 times, most recently
from
April 19, 2022 08:40
f61f33e
to
1434c7f
Compare
Kerollmops
added
the
no breaking
The related changes are not breaking (DB nor API)
label
Apr 19, 2022
Kerollmops
previously approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and thanks for the tests too!
bors merge
👎 Rejected by PR status |
bors merge |
👎 Rejected by PR status |
Kerollmops
force-pushed
the
fix-min-word-len-typo-not-resetting
branch
from
April 19, 2022 13:20
1434c7f
to
8b14090
Compare
Kerollmops
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased on main, just to see!
bors merge
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Access denied is a strange error, I will rerun the merge. |
Already running a review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix min word len for typo not resettign properly, as reported in meilisearch/meilisearch#2330