This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Reintroduce the max values by facet limit #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
added
the
no breaking
Kerollmops
force-pushed
the
reintroduce-max-values-by-facet-limit
branch
from
4ee167a
to
cd7c6e1
Compare
ManyTheFish
reviewed
May 19, 2022
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the max values by facet limit this is related to meilisearch/meilisearch#2349.
I would like some help in deciding on whether I keep the default 100 max values in milli and set up theFacetDistributionsettings in Meilisearch to use 1000 as the new value, I expose themax_values_by_facetfor this purpose.I changed the default value to 1000 and the max to 10000, thank you @ManyTheFish for the help!