This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix escaped quotes in filter #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please update the version of milli so that we can release it immediately? 😇 |
Kerollmops
previously approved these changes
Jun 9, 2022
|
bors merge- |
1 similar comment
|
bors merge- |
|
Canceled. |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix meilisearch/meilisearch#2380
The issue was that in the evaluation of the filter, I was using the deref implementation instead of calling the
valuemethod of my token.To avoid the problem happening again, I removed the deref implementation; now, you need to either call the
lexemeor thevaluemethods but can't rely on a « default » implementation to get a string out of a token.