This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Make binaries faster on release profile through better compile options #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclec
added
no breaking
Kerollmops
suggested changes
Aug 17, 2022
loiclec
force-pushed
the
faster-release-profile
branch
from
fd922af
to
03e679b
Compare
|
They are not read when milli is compiled as a library. But for all the executables that are part of the workspace (benchmarks, cli, etc.), it should make things a bit faster. If we decide to add them to meilisearch, then I think it's best to have them enabled for the benchmarks as well I think. |
|
Build succeeded: |
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Aug 23, 2022
2689: Use mimalloc as the global allocator r=Kerollmops a=loiclec milli has switched its global allocator to mimalloc already, and we have seen some performance gains as a result. Furthermore, we can use mimalloc as the global allocator on all platforms whereas jemalloc was only activated on Linux. This PR brings mimalloc to Meilisearch as well. 2690: Add LTO and codegen-units=1 to release compile options r=Kerollmops a=loiclec This PR brings Meilisearch's release compile options in line with milli (see meilisearch/milli#606 ). Adding LTO and codegen=units=1 will make compile times longer, but they also speed up the final binary significantly. Co-authored-by: Loïc Lecrenier <loic@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
codegen-units = 1andlto = 'thin'makes the compile time a bit longer, but also produces faster binaries.I'd like to run milli's benchmark with these options, so that we can see whether it is worth enabling on meilisearch.