This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Force vendoring of LMDB even if a system version is available #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't use lmdb master3 branch anymore
dureuill
changed the title
dureuill
added
bug
3 tasks
Kerollmops
previously approved these changes
Nov 14, 2022
bors bot
added a commit
that referenced
this pull request
Nov 14, 2022
699: Force vendoring of LMDB even if a system version is available r=irevoire a=dureuill # Pull Request ## Related issue Related to meilisearch/meilisearch#3017: will fix once ported to milli and meilisearch. ## What does this PR do? - Force using vendored version of LMDB - **don't use lmdb master3 branch anymore**: this is a bit of a side effect of using a tag instead of branch for heed as a dependency, but it is wanted anyway for now as lmdb master3 was more of an experiment ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Louis Dureuil <louis@meilisearch.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2022
699: Force vendoring of LMDB even if a system version is available r=irevoire a=dureuill # Pull Request ## Related issue Related to meilisearch/meilisearch#3017: will fix once ported to milli and meilisearch. ## What does this PR do? - Force using vendored version of LMDB - **don't use lmdb master3 branch anymore**: this is a bit of a side effect of using a tag instead of branch for heed as a dependency, but it is wanted anyway for now as lmdb master3 was more of an experiment ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Louis Dureuil <louis@meilisearch.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2022
699: Force vendoring of LMDB even if a system version is available r=irevoire a=dureuill # Pull Request ## Related issue Related to meilisearch/meilisearch#3017: will fix once ported to milli and meilisearch. ## What does this PR do? - Force using vendored version of LMDB - **don't use lmdb master3 branch anymore**: this is a bit of a side effect of using a tag instead of branch for heed as a dependency, but it is wanted anyway for now as lmdb master3 was more of an experiment ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Louis Dureuil <louis@meilisearch.com>
|
Build failed: |
|
The PR now modifies CI to run cargo check on the release rather than the debug artifacts. This is an attempt to reduce the necessary disk space and avoid "out of space" failures. The idea is to avoid duplicating artifacts between debug and release, and also release artifacts are generally leaner |
irevoire
approved these changes
Nov 15, 2022
Kerollmops
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
It is ok for me but @dureuill could you document that in a separate issue because we could probably do better here by probably deleting the target repo or increasing the disk size instead.
bors merge
|
Opened a new issue like requested: meilisearch/meilisearch#3358 |
3 tasks
curquiza
added
DB breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Related to meilisearch/meilisearch#3017: will fix once ported to milli and meilisearch.
What does this PR do?
cargo checkon the release rather than the debug artifacts. This is an attempt to reduce the necessary disk space and avoid "out of space" failures.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!