Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix hard-deletion of an external id that was soft-deleted and then reimported - release-v0.37.5 #754

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

loiclec
Copy link
Contributor

@loiclec loiclec commented Dec 20, 2022

This is a PR that cherry-picks the commit from #750 onto release-v0.37.5

@loiclec loiclec changed the title Fix hard-deletion of an external id that was soft-deleted Fix hard-deletion of an external id that was soft-deleted and then reimported - release-v0.37.5 Dec 20, 2022
@loiclec loiclec added bug Something isn't working no breaking The related changes are not breaking (DB nor API) labels Dec 20, 2022
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the fact the PR is going to be merged into the right branch, but I don't approve the code of course 👌

thanks lo!

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run your fuzzer again on this branch, just in case? 👀

@irevoire
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build succeeded:

@bors bors bot merged commit 0bc7f70 into release-v0.37.5 Dec 20, 2022
@bors bors bot deleted the fix-bug-3021-release-0.37.5 branch December 20, 2022 17:33
@loiclec
Copy link
Contributor Author

loiclec commented Dec 21, 2022

Yes, the fuzz test was done on this branch initially :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants