Add a call to action banner for the cloud #442
Conversation
bidoubiwa
force-pushed
the
add_cloud_banner
branch
2 times, most recently
from
8086aaf
to
8e8b542
Compare
bidoubiwa
force-pushed
the
add_cloud_banner
branch
from
8e8b542
to
f4f3c1f
Compare
|
As commented here, couldn't we use the referral to prevent the banner from being displayed if we come from the cloud? It would prevent us from adding the query param on the Cloud on every link to the mini-dashboard 😄 |
|
It depends on when we would like to use remove the banner. If it is only when someone clicks on their meilisearch instance through the cloud than yes. But if we want to provide a like to share to the search preview without the banner, than it wouldn't work. |
Make sense. Thanks a lot 🙏 |
|
|
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
|
bors merge |
453: Added api-key warning banner r=bidoubiwa a=vaibhav135 # Pull Request ## Related issue Fixes #434 Took creation reference from #442 ## What does this PR do? - Shows api_key (warning) banner. If the api_key is found in the url. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: vaibhav bisht <vaibhavbisht592@gmail.com>
Fixes: #441
A banner now automatically appears at the top of the page with a call to action to the Meilisearch cloud.
To deactivate the banner, you can add
cloud_banner=falseto the query parameters.TODO: