Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade node to version 18 #502

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented May 7, 2024

Pull Request

What does this PR do?

Upgrade node version to v18 in the CI.
This is required to upgrade packages to their latest version (and potentially fix vulnerability issues)
It also upgrades Cypress to its latest, as it is required to work along with its latest GitHub action

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added the maintenance Issue about maintenance (CI, tests, refacto...) label May 7, 2024
@mdubus mdubus force-pushed the upgrade_node_version_to_v18 branch from 98c36cd to 83dd5ac Compare May 7, 2024 13:40
@mdubus mdubus marked this pull request as draft May 7, 2024 14:02
@mdubus mdubus force-pushed the upgrade_node_version_to_v18 branch from 7277c57 to e74fb66 Compare May 7, 2024 14:20
@mdubus mdubus marked this pull request as ready for review May 7, 2024 14:24
@mdubus mdubus requested a review from curquiza May 7, 2024 14:25
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you momo!!

bors merge

Copy link
Contributor

meili-bors bot commented May 7, 2024

@meili-bors meili-bors bot merged commit bd1fcd5 into main May 7, 2024
5 checks passed
@meili-bors meili-bors bot deleted the upgrade_node_version_to_v18 branch May 7, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants