Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Settings API - Typo Tolerance #117

Merged
merged 50 commits into from May 13, 2022
Merged

Settings API - Typo Tolerance #117

merged 50 commits into from May 13, 2022

Conversation

gmourier
Copy link
Member

@gmourier gmourier commented Feb 22, 2022 •
edited

Naming proposals are open until 2022-03-31
The definitive specification is due at 2022-04-01

Summary

This specification describes the configuration options for the typo tolerance settings.

🤖 API Diff
📄 Rendered

  • Freeze parameter naming choices
  • typo or typoTolerance setting name
  • Add dedicated errors for the typo tolerance API resource
  • Branch telemetry to the typo tolerance customization
  • Update OpenAPI specification
  • Add examples for minWordSizeForTypos
  • Describes Async/Sync errors

Dependent of #123

Key Points

  • Add a typoTolerance index settings resource to manage customization of typo tolerance feature at index level.
    • Expose typoTolerance object on /indexes/:index_uid/settings endpoints.
    • Add GET/POST/DELETE - /indexes/:index_uid/settings/typo-tolerance endpoints.
  • typoTolerance object definition is made of the following properties:
    • enabled: Whether the typo tolerance feature is enabled. (Default: true)
    • disableOnAttributes: Disable the typo tolerance feature on the specified document attributes. (Default: [])
    • disableOnWords: Disable the typo tolerance feature for a set of query terms given during a search query. (Default: [])
    • minWordSizeForTypos:
      • oneTypo: Customize the minimum size for a word to tolerate 1 typo (Default: 5)
      • twoTypos: Customize the minimum size for a word to tolerate 2 typos (Default: 9)

Informations To Reviewers

We could naturally think of putting the typo tolerance customization in the rankingRules typo.

This seems to be a bad idea for several reasons that have been evaluated previously:

  • The rankingRules become less intuitive by doing multiple things. Currently, its purpose is to configure the ordering of the search results given ranking rules positioning.
  • It would probably make reading the ranking rules more difficult if a full typo object is described.
  • Moreover, if removing typo from the ranking rules settings deactivates the typo tolerance feature and the configuration of typo properties are located in the ranking rule, a user may lose information if the ranking rule is removed to deactivate it.
  • In the future, if we want to expose the typo tolerance properties at search time for customization purposes. It will force us to add the customization of rankingRules at search time. Thus, rankingRules need to be updated to manage objects (Currently, it's an array of strings).

As you can see, there are a lot of things that are not desirable if we decide to manage all the typo tolerance properties within the typo ranking rule.

@gmourier gmourier added the In Progress Feature specification is in elaboration. Important changes can still occurs in the specification. label Feb 22, 2022
@gmourier gmourier added this to In Progress in Specification Workflow Feb 28, 2022
@gmourier gmourier changed the title Typo Tolerance Customize Typo Tolerance Feb 28, 2022
@meilisearch meilisearch deleted a comment from github-actions bot Feb 28, 2022
@meilisearch meilisearch deleted a comment from github-actions bot Feb 28, 2022
@gmourier gmourier changed the title Customize Typo Tolerance Typo Tolerance Mar 1, 2022
@gmourier gmourier changed the title Typo Tolerance Customize Typo Tolerance at Indexing time / Search time Mar 1, 2022
@gmourier gmourier marked this pull request as ready for review March 1, 2022 13:57
@gmourier gmourier added v0.27 OpenAPI Update OpenAPI specification. Telemetry Update the telemetry collect. labels Mar 1, 2022
@gmourier gmourier changed the title Customize Typo Tolerance at Indexing time / Search time Settings API / Search API - Customize Typo Tolerance Mar 1, 2022
@gmourier gmourier changed the title Settings API / Search API - Customize Typo Tolerance Settings API - Typo Tolerance Mar 2, 2022
@gmourier gmourier self-assigned this Mar 3, 2022
@gmourier gmourier added the P2 label Mar 7, 2022
@curquiza curquiza mentioned this pull request Mar 7, 2022
Closed
4 tasks
@bidoubiwa
Copy link
Contributor

bidoubiwa commented Mar 8, 2022 •
edited

Hello!

Add a typoTolerance setting to manage customization of typo tolerance feature at index level.

👍 I agree on not adding it in the ranking rules

enabled: Whether the typo tolerance feature is enabled. (Default: true)

👍

disableOnAttributes: Disable the typo tolerance feature on the specified document attributes. (Default: [])

What do you think of disabledAttributes?

disableOnWords: Disable the typo tolerance feature for a set of query terms given during a search query. (Default: [])

What do you think of disabledWords?

minWordSizeFor1Typo: Customize the minimum size for a word to tolerate 1 typo. (Default: 5)
minWordSizeFor2Typos: Customize the minimum size for a word to tolerate 2 typos (Default: 9)

Fiou this is a complex setting 😱 I would not add a number in the setting name. I don't think it is very common to do that. But I'm not sure either.
I feel like the name is complex but I have no better options to suggest, so until then I agree with this one.

Force the definition of the whole payload on POST /indexes/:index_uid/settings/typo_tolerance ?

👍

I think we should force the whole payload. I also think this is the expected behavior. This means that in the case the update is partial, the user could potentially think they removed some settings to reset to the default ones but in fact, it will still be the old value.

Regarding the use of the POST verb, we could change it during v0.28 to PATCH during the API stabilization since it seems to better embrace the REST convention.

In which case, the partial update would make more sense indeed!

bidoubiwa
bidoubiwa reviewed Mar 8, 2022
View reviewed changes
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
@gmourier
Copy link
Member Author

gmourier commented Mar 9, 2022

@bidoubiwa I have no preference between disableOnAttributes/disableOnWords or disabledAttributes/disabledWords. Both work for me!

@gmourier gmourier added Ready For Review Feature specification must be reviewed. and removed In Progress Feature specification is in elaboration. Important changes can still occurs in the specification. labels Mar 9, 2022
@gmourier gmourier moved this from In Progress to Ready For Review in Specification Workflow Mar 9, 2022
brunoocasali
brunoocasali reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gmourier this is my first review, I will learn more about the whole typo matching feature in order to help more regarding this config 😉

open-api.yaml Show resolved Hide resolved
open-api.yaml Show resolved Hide resolved
open-api.yaml Show resolved Hide resolved
text/0034-telemetry-policies.md Outdated Show resolved Hide resolved
text/0034-telemetry-policies.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
open-api.yaml Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
text/0117-typo-tolerance-settings-api.md Outdated Show resolved Hide resolved
@gmourier gmourier added P1 and removed P2 labels Mar 14, 2022
@gmourier gmourier deleted the typo-tolerance branch May 13, 2022 09:55
@gmourier gmourier added Implemented Feature specification has been implemented. and removed Ready For Review Feature specification must be reviewed. P1 labels May 13, 2022
@gmourier gmourier moved this from Ready to be implemented to Implemented in Specification Workflow May 13, 2022
gmourier added a commit that referenced this pull request May 13, 2022
@gmourier @bidoubiwa
@brunoocasali @MarinPostma @dichotommy
Settings API - Typo Tolerance (#117)
ca37f45 
* Draft file for Typo Tolerance specification

* rename spec file

* Rename specification

* draft

* Add open-api.yaml prototype

* Add typoTolerance component on POST search

* Add typoTolerance object into search api parameters

* fix typos

* remove the past tense

* Add typoTolerance GET query parameters

* Fix description

* Add explanations for disableOnWords property

* Update spec href

* Describe indexes/:index_uid/settings/typo-tolerance endpoint

* Explain why it is useful to expose typo tolerance settings at search time

* Remove typoTolerance properties at search time

* Add a future possiblity to change POST verb to PATCH to edit a settings partially

* Sync spec with telemetry

* Mark TODO on technical details and rework structure of specification

* Specify properties required to false to allow partial updates

* Add error definitions for typoTolerance API resource properties

* Rename spec file

* Restore deleted metric

* Update text/0117-typo-tolerance-settings-api.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Update text/0117-typo-tolerance-settings-api.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>

* Replace W to w in telemtry

* Apply consistency on new errors message

* fix typo

* Add Async Errors and Lazy Index Creation

* Rename telemetry nodes

* Mention case insensivity of disableOnWords parameter

* Describes synchronous (type-checking)  and asynchronous (business logic) errors

* Add examples for minWordSizeFor1Typo and minWordSizeFor2Typos

* Elaborate on examples

* Remove title bullet point

* Apply naming suggestions

* Apply naming changes on telemetry and miss on OpenAPI

* Branch typo sub-ressource to settings-api specification

* Fix typo (lul)

* Add Technical Details

* Apply suggestions from code review

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Replace minWordSizeForXTypos fields by a minWordSizeForTypos object

* Update text/0034-telemetry-policies.md

Co-authored-by: ad hoc <postma.marin@protonmail.com>

* Apply suggestions from code review

Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

* Remove dedicated error for type checking

* Update text/0034-telemetry-policies.md

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>

* Bring naming changes

* Fix metrics name for typo_tolerance

* Update text/0034-telemetry-policies.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: ad hoc <postma.marin@protonmail.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
gmourier added a commit that referenced this pull request May 16, 2022
@gmourier @curquiza
@ManyTheFish @bidoubiwa @maryamsulemani97 @guimachiavelli @brunoocasali @MarinPostma @dichotommy @Kerollmops @qdequele @irevoire
Release v0.27.0 (#129)
b536fb7 
* Instance Options (#119)

* Add instance options spec

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Numeric title + add dump options

* Add link to dump spec

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Add title numerotations

* Add telemetry for new options

* Apply changes after the review

* Update text/0119-instance-options.md

* Update text/0119-instance-options.md

Co-authored-by: Many <legendre.maxime.isn@gmail.com>

* Update text/0119-instance-options.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Update text/0119-instance-options.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Change naming after the review

* Update text/0034-telemetry-policies.md

* Update text/0034-telemetry-policies.md

* Update text/0034-telemetry-policies.md

* Update text/0034-telemetry-policies.md

* Apply suggestions from code review

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Update text/0119-instance-options.md

Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>

* Update text/0119-instance-options.md

Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Many <legendre.maxime.isn@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Settings API - v0.26.0 state (#123)

* Add a Settings API specification file

* Add distinct-attribute-setting-api.md

* Add displayed-attributes and searchable-attributes specification file

* Add stop-words setting api

* Add synonyms setting api

* Rename spec files and fix some typos

* Add ranking rules setting api

* Add filterable-attributes and sortable-attributes settings API

* Add a Triggering Documents Re-Indexing technical section

* Rephrase 202 Accepted Response for POST Methods

* Apply Triggering Documents Re-Indexing Technical part on related sub settings

* Update synonyms setting api file

* Precise and rephrase some sentences

* Remove bullet point title

* Add limitation about manually specifying searchableAttributes

* Update spec template according to our current usage (#127)

* Update spec template according to our current usage

* Update text/0000-specification-template.md

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Remove bullet point dedicated to title

* Rename Technical Aspects to Technical Details

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>

* Documents API (#133)

* Catch-up documents api specification

* Add precisions and examples

* Apply suggestions from code review

Co-authored-by: Many <legendre.maxime.isn@gmail.com>

Co-authored-by: Many <legendre.maxime.isn@gmail.com>

* Stats API (#134)

* Add Stats API specification

* Rename spec file with pr number

* Clean typo, add precisions and fix inner linking

* Apply suggestions from code review

Co-authored-by: maryamsulemani97 <90181761+maryamsulemani97@users.noreply.github.com>

* Change order of API endpoints

Co-authored-by: maryamsulemani97 <90181761+maryamsulemani97@users.noreply.github.com>

* Errors - Add variant for `invalid_filter`/`invalid_sort` when related settings are empty (#125)

* Add variant for invalid_sort and invalid_filter errors when settings are empty

* Update text/0061-error-format-and-definitions.md

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

* Add missing "v" in the user-agent data (#136)

Following the issue meilisearch/integration-guides#150 there is a "v" before the version of the package.

* Indexes API (#132)

* Catch-up Indexes API

* Add details by field for an Index API Resource

* fix typo

* Add future possibilities

* Apply suggestions from code review

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Add precisions from review

* lowercase type

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Remove never-implemented and deprecated 0042-paginated-search.md (#147)

* Settings API - Typo Tolerance (#117)

* Draft file for Typo Tolerance specification

* rename spec file

* Rename specification

* draft

* Add open-api.yaml prototype

* Add typoTolerance component on POST search

* Add typoTolerance object into search api parameters

* fix typos

* remove the past tense

* Add typoTolerance GET query parameters

* Fix description

* Add explanations for disableOnWords property

* Update spec href

* Describe indexes/:index_uid/settings/typo-tolerance endpoint

* Explain why it is useful to expose typo tolerance settings at search time

* Remove typoTolerance properties at search time

* Add a future possiblity to change POST verb to PATCH to edit a settings partially

* Sync spec with telemetry

* Mark TODO on technical details and rework structure of specification

* Specify properties required to false to allow partial updates

* Add error definitions for typoTolerance API resource properties

* Rename spec file

* Restore deleted metric

* Update text/0117-typo-tolerance-settings-api.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Update text/0117-typo-tolerance-settings-api.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>

* Replace W to w in telemtry

* Apply consistency on new errors message

* fix typo

* Add Async Errors and Lazy Index Creation

* Rename telemetry nodes

* Mention case insensivity of disableOnWords parameter

* Describes synchronous (type-checking)  and asynchronous (business logic) errors

* Add examples for minWordSizeFor1Typo and minWordSizeFor2Typos

* Elaborate on examples

* Remove title bullet point

* Apply naming suggestions

* Apply naming changes on telemetry and miss on OpenAPI

* Branch typo sub-ressource to settings-api specification

* Fix typo (lul)

* Add Technical Details

* Apply suggestions from code review

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Replace minWordSizeForXTypos fields by a minWordSizeForTypos object

* Update text/0034-telemetry-policies.md

Co-authored-by: ad hoc <postma.marin@protonmail.com>

* Apply suggestions from code review

Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

* Remove dedicated error for type checking

* Update text/0034-telemetry-policies.md

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>

* Bring naming changes

* Fix metrics name for typo_tolerance

* Update text/0034-telemetry-policies.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: ad hoc <postma.marin@protonmail.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

* Data Types - Add Nested Fields Support (#121)

* Add a draft spec with nested fields flattening examples

* Consitent phrasing

* Fix markdown syntax

* Add null section

* Add Object example section

* Apply suggestions from code review

Co-authored-by: Clément Renault <renault.cle@gmail.com>

* Rename spec file to PR id

* Add special searchableAttributes default case with flattening alg

* Rephrase document structure representation

* Add a dotnotation section

* Add dot-notation section

* Update text/0121-data-types.md

Co-authored-by: Quentin de Quelen <quentin@meilisearch.com>

* Add Future Possibilities

* Rework nested notation sections

* Fix TODO and mention the . notation and all properties notation

* Add a edge case section

* Fix missing block code marker

* Update text/0123-ranking-rules-setting-api.md

Co-authored-by: Clément Renault <renault.cle@gmail.com>

* Apply suggestions from code review

Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Clément Renault <renault.cle@gmail.com>

* Fix section number

* Remove unclear sentence

* Remove dedicated object section

Co-authored-by: Clément Renault <renault.cle@gmail.com>
Co-authored-by: Quentin de Quelen <quentin@meilisearch.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

* Search API - Formatting Search Results (#120)

* Draft a revamp of the formatting search results spec

* Removes formatting-search-results specification

* wip

* Fix links

* Add precision

* Update OpenAPI

* Fix sentences

* Add consistency

* Add details and fix sentences

* Fix default value in OpenAPI spec

* Add Future Possibilities for _matchesInfo

* Remove bullet point title

* Add wip examples

* Add _formatted behavior regarding attributesToRetrieve, attributesToCrop and attributesToHighlight

* Apply suggestions from code review

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Fix typo

* Mention no effect case of  cropMarker / cropLength / highlightPostTag / highlightPreTag  on attributesToCrop  & attributesToHighlight

* Re-explain _formatted in details

* Mention Synonyms

* Add precision after team feedback

* Apply suggestions from code review

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>

* Add precisions

* Add boolean analytics for fields dedicated to customize formatting of search results behaviors

* Precise behavior for _formatted

* Add clearer explanations for the cropping algorithm and the fact that it keep the phrase context when extending around

* Apply suggestions from code review

Co-authored-by: Many <legendre.maxime.isn@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>

* Precise highlighting around every matched query term

* Apply suggestions from code review

Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Precise cropLength behavior when 0 is specified

* Remove filter-and-facet-behavior spec to merge it into search-api, and correct some types description

* Improve formatted spec (#146)

* Improve formatted spec

* Update text/0118-search-api.md

Co-authored-by: Tamo <irevoire@protonmail.ch>

* Update text/0118-search-api.md

Co-authored-by: Tamo <irevoire@protonmail.ch>

* Update text/0118-search-api.md

Co-authored-by: Tamo <irevoire@protonmail.ch>

* Update text/0118-search-api.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Update text/0118-search-api.md

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Improve according to reviews

Co-authored-by: Tamo <irevoire@protonmail.ch>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Add missing precision for highlightPostTag

* fix broken links

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: Many <legendre.maxime.isn@gmail.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
Co-authored-by: Tamo <irevoire@protonmail.ch>

* Bump API to v0.27.0 version

Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
Co-authored-by: Many <legendre.maxime.isn@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: maryamsulemani97 <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: ad hoc <postma.marin@protonmail.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Clément Renault <renault.cle@gmail.com>
Co-authored-by: Quentin de Quelen <quentin@meilisearch.com>
Co-authored-by: Tamo <irevoire@protonmail.ch>
bors bot added a commit to meilisearch/meilisearch-java that referenced this pull request May 25, 2022
@bors @alallema
Merge #371
9073c17 
371: Add typo tolerance settings r=alallema a=alallema

⚠️ This PR is a `WIP` it will be merged after the v0.27.0

This PR introduces the new setting: [typoTolerance](meilisearch/specifications#117)

new methods: 
`index.getTypoTolerance()`
`index.updateTypoTolerance(params)`
`index.resetTypoTolerance()`

Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
This was referenced Jul 16, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
daFish added a commit to daFish/meilisearch-symfony that referenced this pull request Nov 5, 2022
@daFish
feat(settings): add support for typoTolerance
396bbd0 
This change adds the ability to specify the `typeTolerance`
as described in meilisearch/specifications#117
@daFish daFish mentioned this pull request Nov 5, 2022
Merged
3 tasks
bors bot added a commit to meilisearch/meilisearch-symfony that referenced this pull request Nov 7, 2022
@bors @daFish
Merge #207
952c0ae 
207: feat(settings): add support for `typoTolerance` r=brunoocasali a=daFish

This change adds the ability to specify the `typoTolerance` as described in meilisearch/specifications#117

# Pull Request

## Related issue
Fixes #179

## What does this PR do?
- This change adds the ability to specify `typoTolerance` for a given index.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Marcus Stöhr <mstoehr@brainbits.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops left review comments

@brunoocasali brunoocasali brunoocasali left review comments

@MarinPostma MarinPostma MarinPostma left review comments

@bidoubiwa bidoubiwa bidoubiwa left review comments

@maryamsulemani97 maryamsulemani97 maryamsulemani97 left review comments

@alallema alallema alallema left review comments

@dichotommy dichotommy Awaiting requested review from dichotommy

@ManyTheFish ManyTheFish Awaiting requested review from ManyTheFish

Assignees

@gmourier gmourier

Labels
Implemented Feature specification has been implemented. OpenAPI Update OpenAPI specification. Q2:2022 Telemetry Update the telemetry collect. v0.27
Projects
Specification Workflow
Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@gmourier @bidoubiwa @MarinPostma @alallema @maryamsulemani97 @dichotommy @Kerollmops @brunoocasali @ManyTheFish