This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add proximity precision setting #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
macraig
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
The spec is super clear and easy to read, thanks @ManyTheFish ! ✨
2 tasks
macraig
reviewed
Jan 4, 2024
macraig
reviewed
Jan 4, 2024
macraig
reviewed
Jan 4, 2024
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 8, 2024
4303: Display default value when proximityPrecision is not set r=dureuill a=ManyTheFish # Pull Request ## Related Issue: #4187 Spec change requests: meilisearch/specifications#261 (comment) ## What does this PR do? - Display default value when proximityPrecision is not set instead of Null Co-authored-by: ManyTheFish <many@meilisearch.com>
Co-authored-by: Maria Craig <maria@meilisearch.com>
Co-authored-by: Maria Craig <maria@meilisearch.com>
Co-authored-by: Maria Craig <maria@meilisearch.com>
ManyTheFish
commented
Jan 10, 2024
macraig
added a commit
that referenced
this pull request
Jan 15, 2024
* Bump API version * Add proximity precision setting (#261) * Add proximity precision setting * Update text/0034-telemetry-policies.md Co-authored-by: Maria Craig <maria@meilisearch.com> * Update text/0034-telemetry-policies.md Co-authored-by: Maria Craig <maria@meilisearch.com> * Update text/0034-telemetry-policies.md Co-authored-by: Maria Craig <maria@meilisearch.com> * Update text/0123-settings-api.md * Update text/0123-proximity-precision.md * Update text/0123-proximity-precision.md --------- Co-authored-by: Maria Craig <maria@meilisearch.com> * write the task queue webhook specification (#262) --------- Co-authored-by: María <maria@Marias-MacBook-Pro.local> Co-authored-by: Many the fish <legendre.maxime.isn@gmail.com> Co-authored-by: Tamo <tamo@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Define the
proximityPrecisionsetting.Changes