This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Add details
payload by task type and index deletion behavior on task retrieval
#90
Merged
gmourier
merged 1 commit into
develop
from
patch-refashion-update-api-for-index-deletion
Nov 16, 2021
Merged
Add details
payload by task type and index deletion behavior on task retrieval
#90
gmourier
merged 1 commit into
develop
from
patch-refashion-update-api-for-index-deletion
Nov 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
MarinPostma
reviewed
Nov 15, 2021
MarinPostma
approved these changes
Nov 16, 2021
MarinPostma
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 2, 2021
https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 - meilisearch/specifications#90
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 2, 2021
1796: Feature branch: Task store r=irevoire a=MarinPostma # Feature branch: Task Store ## Spec todo https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. ## Todo tech - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions ## Implementation ### Linked PRs - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 ### Linked PRs in milli: - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 ### Issues - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 ### Spec patches - meilisearch/specifications#90 Co-authored-by: Marin Postma <postma.marin@protonmail.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 2, 2021
1796: Feature branch: Task store r=irevoire a=MarinPostma # Feature branch: Task Store ## Spec todo https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. ## Todo tech - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions ## Implementation ### Linked PRs - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 ### Linked PRs in milli: - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 ### Issues - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 ### Spec patches - meilisearch/specifications#90 Co-authored-by: Marin Postma <postma.marin@protonmail.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 2, 2021
1796: Feature branch: Task store r=irevoire a=MarinPostma # Feature branch: Task Store ## Spec todo https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. ## Todo tech - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions ## Implementation ### Linked PRs - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 ### Linked PRs in milli: - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 ### Issues - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 ### Spec patches - meilisearch/specifications#90 Co-authored-by: Marin Postma <postma.marin@protonmail.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 2, 2021
1796: Feature branch: Task store r=irevoire a=MarinPostma # Feature branch: Task Store ## Spec todo https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. ## Todo tech - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions ## Implementation ### Linked PRs - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 ### Linked PRs in milli: - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 ### Issues - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 ### Spec patches - meilisearch/specifications#90 Co-authored-by: Marin Postma <postma.marin@protonmail.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 2, 2021
1796: Feature branch: Task store r=irevoire a=MarinPostma # Feature branch: Task Store ## Spec todo https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. ## Todo tech - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions ## Implementation ### Linked PRs - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 ### Linked PRs in milli: - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 ### Issues - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 ### Spec patches - meilisearch/specifications#90 Co-authored-by: Marin Postma <postma.marin@protonmail.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Dec 3, 2021
1796: Feature branch: Task store r=irevoire a=MarinPostma # Feature branch: Task Store ## Spec todo https://github.com/meilisearch/specifications/blob/develop/text/0060-refashion-updates-apis.md - [x] The update resource is renamed task. The names of existing API routes are also changed to reflect this change. - [x] Tasks are now also accessible as an independent resource of an index. GET - /tasks; GET - /tasks/:taskUid - [x] The task uid is not incremented by index anymore. The sequence is generated globally. - [x] A task_not_found error is introduced. - [x] The format of the task object is updated. - [x] updateId becomes uid. - [x] Attributes of an error appearing in a failed task are now contained in a dedicated error object. - [x] type is no longer an object. It now becomes a string containing the values of its name field previously defined in the type object. - [x] The possible values for the type field are reworked to be more clear and consistent with our naming rules. - [x] A details object is added to contain specific information related to a task payload that was previously displayed in the type nested object. Previous number key is renamed numberOfDocuments. - [x] An indexUid field is added to give information about the related index on which the task is performed. - [x] duration format has been updated to express an ISO 8601 duration. - [x] processed status changes to succeeded. - [x] startedProcessingAt is updated to startedAt. - [x] processedAt is updated to finishedAt. - [x] 202 Accepted requests previously returning an updateId are now returning a summarized task object. - [x] MEILI_MAX_UDB_SIZE env var is updated MEILI_MAX_TASK_DB_SIZE. - [x] --max-udb-size cli option is updated to --max-task-db-size. - [x] task object lists are now returned under a results array. - [x] Each operation on an index (creation, update, deletion) is now asynchronous and represented by a task. ## Todo tech - [x] Restore Snapshots - [x] Restore dumps of documents - [x] Implements the dump of updates - [x] Error handling - [x] Fix stats - [x] Restore the Analytics - [x] [Add the new analytics](https://github.com/meilisearch/specifications/pull/92/files) - [x] Fix tests - [x] ~Deleting tasks when index is deleted (see bellow)~ see #1891 instead - [x] Improve details for documents addition and deletion tasks - [ ] Add integration test - [ ] Test task store filtering - [x] Rename `UuidStore` to `IndexMetaStore`, and simplify the trait. - [x] Fix task store initialization: fill pending queue from hard state - [x] Synchronously return error when creating an index with an invalid index_uid and add test - [x] Task should be returned in decreasing uid + tests (on index task route) - [x] Summarized task view - [x] fix snapshot permissions ## Implementation ### Linked PRs - #1889 - #1891 - #1892 - #1902 - #1906 - #1911 - #1914 - #1915 - #1916 - #1918 - #1924 - #1925 - #1926 - #1930 - #1936 - #1937 - #1942 - #1944 - #1945 - #1946 - #1947 - #1950 - #1951 - #1957 - #1959 - #1960 - #1961 - #1962 - #1964 ### Linked PRs in milli: - meilisearch/milli#414 - meilisearch/milli#409 - meilisearch/milli#406 - meilisearch/milli#418 ### Issues - close #1687 - close #1786 - close #1940 - close #1948 - close #1949 - close #1932 - close #1956 ### Spec patches - meilisearch/specifications#90 Co-authored-by: Marin Postma <postma.marin@protonmail.com>
gmourier
added a commit
that referenced
this pull request
Jan 4, 2022
gmourier
added a commit
that referenced
this pull request
Jan 11, 2022
* Refashion Update APIs (#60) * start a draft specification * Update discovery issue * Add new task object format and new API endpoints * Remove an information hint * replace emojis for short hint points * add specification for each API endpoints * update task_not_found error * replace error field to match next version of error object format * update open-api.yml and change duration format to be an ISO-8601 duration format * add branch ref to bump.yml worflow * mention MEILI_MAX_UDB_SIZE and --max-udb-size changes * update Summary Key Points * Update task_not_found error definition * fix missing part * Update text/0060-refashion-updates-apis.md Co-authored-by: gui machiavelli <gui@meilisearch.com> * fix details part * remove WordsPosition in valid examples * mention global sequence of task uid * Update specification number * Add part about asynchronous write on index resource * Mention lazy index creation * Add future possibility about merging documentsAddition and documentsPartial into one type * Mention ISO-8601 duration format under the second Co-authored-by: gui machiavelli <gui@meilisearch.com> * add Task details by type definition (#90) * Update telemetry-policies spec to match task endpoints metrics (#92) * Patch Task specification for details part. (#93) * add details about the first Launched event to an aggregated segment userId (#94) * Replace q.avg_terms_number by q.max_terms_number (#95) * API keys (#85) * init spec * update pr link * Update specification * update spec and add part on Scoped API Keys * update summary key points * fix typos * test markdown link * describe errors and reference new errors on the errors specification * remove double space and typos * Use patch verb instead of put to handle partial update of API Key * update default api keys description * update error links * fix wrong formatted api endpoints * update summary key changes * Move Scoped API Keys part to a dedicated specification * update technical details * Implement /keys endpoints * update open-api.yaml to match develop * update keys part * fix operationId * move /keys endpoints * Update Summary of new /keys endpoints * add master key explanation and behavior * update response resource representation for POST and PUT methods * Apply suggestions from code review Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * rename master occurences by main * Apply suggestions from code review Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> * Update open-api.yaml Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> * Update open-api.yaml Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> * remove occurences of PUT by PATCH * update tasks.get to tasks and mention that dumps is not affected by the indexes restrictions * add consistency into action names * reorder example and fields table to desired order * Try another titles numeric format * Rephrase and make it obvious that API Keys writes operations are synchronous * fix description of indexes and actions parameters for the Key API resource * Add dedicated section for Default Search Key and upgrading to v0.25.0 impact * Correct section title * Keep master-key and explain upgrade behavior from a version prior to v0.25 * Replace X-MEILI-API-KEY header by the Authorization header with the bearer authorization method * Mention API Keys transitionning to snapshots * Mention keys resource propagation via dumps and snapshots in Summary Key Points * Replace old references of expiresInSeconds by expiresAt in example * Update text/0085-api-keys.md Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com> * update OAS to remove mention * Update OAS MeiliSearch version * Update examples for updatedAt field * Add mention of the storage size limit for the API keys * update auth scheme in OAS * SECURITY CHANGES - Changes storage and explain randomized prefix generation and SHA-256 hash combination with the master-key * Update text/0085-api-keys.md Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * Update text/0085-api-keys.md Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * mention listing of expired API keys on /keys * Add rfc2822 format for expiredAt as a future possibilities * Remove propagating of newly created index to a non default array * Add master-key format * Replace generated by created Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com> * Replace indexes.add by indexes.create for consistency (#99) * Fixing documentAddition, documentPartial and documentDeletion task type typo in naming (#101) * Patch Async/Sync part of errors definition (#100) * rename refashion updates apis specification file (#103) * bump API version to 0.25.0 * OAS: Update documentation page link for asynchronous tasks * OAS: Update documentation page link for security * OAS: Update tasks list field data to results * OAS: Update task schema and examples * OAS: remove settings.reset action for API Key ressource * OAS: add missing security schema and add results array for tasks list * fix typo * update responses examples Co-authored-by: gui machiavelli <gui@meilisearch.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Details definition
We have the possibility to add more information than initially planned. We propose to add essentially a diff detail for tasks that are supposed to receive documents and finally index some or all of them.
documentsAddition
/documentsPartial
/documentsDeletion
.We also specify which
primaryKey
is sent for index creation and update if it is filled in.For
settingsUpdate
task type, thedetails
field does not change.Deleting an index
Deleting an index means that tasks for that index can no longer be found via
indexes/:indexName/tasks
. However, they are still accessible via/tasks
for this version.