Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add set-design.md #44

Merged
merged 11 commits into from
Mar 5, 2019
Merged

add set-design.md #44

merged 11 commits into from
Mar 5, 2019

Conversation

gengxinMT
Copy link
Contributor

@gengxinMT gengxinMT commented Jan 23, 2019 •
edited by shafreeck
Loading

SET 相关设计

@shafreeck shafreeck mentioned this pull request Jan 23, 2019
Closed
@YIDWang
Copy link
Contributor

YIDWang commented Jan 24, 2019

英语提交吧？可以找人帮着翻译

@YIDWang YIDWang closed this Jan 24, 2019
@shafreeck
Copy link
Contributor

中英文都需要提供，需要有个地方讨论当前的设计是否合理，我重新开一下这个PR

@shafreeck shafreeck reopened this Jan 28, 2019
@shafreeck shafreeck assigned shafreeck and gengxinMT and unassigned shafreeck Jan 28, 2019
@shafreeck shafreeck added enhancement New feature or request proposal New feature design with significant changes labels Jan 28, 2019
arthurkiller
arthurkiller approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@arthurkiller arthurkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shafreeck
shafreeck requested changes Feb 1, 2019
View reviewed changes
proposals/set-design.md Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
@YIDWang
Copy link
Contributor

YIDWang commented Feb 1, 2019

Set不能有重复的数据，如果多次添加相同元素，Set中将仅保留该元素的一份拷贝。

没有描述清楚，当前设计中 字段中有一个 更新创建时间，这个需要考虑如何更新

@YIDWang
Copy link
Contributor

YIDWang commented Feb 1, 2019

SAdd key member
sadd 应该是添加新的key，更新旧的key。（可以参考一下meta里面的 几个创建时间，更新时间字段）

@YIDWang
Copy link
Contributor

YIDWang commented Feb 1, 2019

SPop key 随机的方式描述清楚

@YIDWang
Copy link
Contributor

YIDWang commented Feb 1, 2019

SInter 当前这种实现性能太低了，
主要是应该场景上看，是否可以更改基本数据结构。
例如
用空间换时间
增加一列key （member到key的映射）
或者采用多个key 进行并发取并集

YIDWang
YIDWang requested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@YIDWang YIDWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前设计不适合大数据量场景 ，假如不考虑大数量的使用场景，可以按照当前方式实现。

@YIDWang
Copy link
Contributor

YIDWang commented Feb 1, 2019

从第二个集合开始遍历后续每个集合的member，将两个集合中都存在的元素作为下一次操作的基准，直至操作全部完成。

这个遍历可以详细描述一下如何遍历的？？？

shafreeck
shafreeck requested changes Feb 1, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
@shafreeck shafreeck mentioned this pull request Feb 1, 2019
Open
nightmeng
nightmeng requested changes Feb 1, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
@YIDWang
Copy link
Contributor

YIDWang commented Feb 21, 2019

Set不能有重复的数据，如果多次添加相同元素，Set中将仅保留该元素的一份拷贝。

没有描述清楚，当前设计中 字段中有一个 更新创建时间，这个需要考虑如何更新

@YIDWang YIDWang reopened this Feb 21, 2019
@YIDWang
Copy link
Contributor

YIDWang commented Feb 21, 2019

从第二个集合开始遍历后续每个集合的member，将两个集合中都存在的元素作为下一次操作的基准，直至操作全部完成。

这个遍历可以详细描述一下如何遍历的？？？

@YIDWang YIDWang closed this Feb 21, 2019
@YIDWang YIDWang reopened this Feb 22, 2019
@YIDWang
Copy link
Contributor

YIDWang commented Feb 22, 2019

重新打开

shafreeck
shafreeck reviewed Feb 26, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
shafreeck
shafreeck reviewed Feb 26, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
@shafreeck @gengxinMT
Update proposals/set-design.md
ab9692c 
Co-Authored-By: gengxinMT <41134652+gengxinMT@users.noreply.github.com>
codelingo[bot]
codelingo bot reviewed Feb 26, 2019
View reviewed changes
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codelingo[bot]
codelingo bot reviewed Feb 26, 2019
View reviewed changes
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shafreeck
shafreeck reviewed Feb 26, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
shafreeck
shafreeck reviewed Feb 26, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
codelingo[bot]
codelingo bot reviewed Feb 26, 2019
View reviewed changes
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shafreeck
shafreeck reviewed Feb 26, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
shafreeck
shafreeck requested changes Feb 26, 2019
View reviewed changes
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
proposals/set-design.md Outdated Show resolved Hide resolved
codelingo[bot]
codelingo bot reviewed Feb 26, 2019
View reviewed changes
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shafreeck
shafreeck approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthurkiller arthurkiller merged commit ed22c03 into master Mar 5, 2019
@gengxinMT gengxinMT deleted the feature/set-design branch March 5, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelingo CodeLingo codelingo left review comments

@shafreeck shafreeck shafreeck approved these changes

@nightmeng nightmeng nightmeng approved these changes

@arthurkiller arthurkiller arthurkiller approved these changes

@YIDWang YIDWang YIDWang approved these changes

@jl2005 jl2005 Awaiting requested review from jl2005

@nioshield nioshield Awaiting requested review from nioshield

Assignees

@gengxinMT gengxinMT

Labels
enhancement New feature or request proposal New feature design with significant changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengxinMT @YIDWang @shafreeck @nightmeng @arthurkiller