Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix time parse]#3 #13

Merged
merged 1 commit into from
May 26, 2022
Merged

[fix time parse]#3 #13

merged 1 commit into from
May 26, 2022

Conversation

myksl
Copy link
Collaborator

@myksl myksl commented May 26, 2022

What is the purpose of the change

fix bug #3

Brief Changelog

There will be problems with the parsing of special time types. This time, we have made special parsing for special times.

Verify this change

  • Make sure there is a GitHub_issue field for changes (usually before you start working on it). Trivial changes like spelling mistakes do not require GitHub issues. Your pull request should only address this issue and no other changes - one PR addresses one issue.
  • Every commit in a pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write the necessary unit tests to verify your logic corrections, mocks work better when there are cross-module dependencies.
  • GitHub Actions works fine on your own fork.

}
stringDateTime = String.format("%04d-%02d-%02d %02d:%02d:%02d", year, month, day, hour, minute, second);
return Pair.of(millisDateTime.getMillis(), stringDateTime);
return Pair.of(validDateTime.getMillis(), invalidDateTime);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can sdk get the invalidDateTime from event?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datetime2ToTimestamp will call it

@lvfeifei08 lvfeifei08 merged commit 15a108f into meituan:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants