Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get a laser to consistently point up or down #4942

Closed
MalcolmAnderson opened this issue Feb 14, 2018 · 10 comments
Closed

Can't get a laser to consistently point up or down #4942

MalcolmAnderson opened this issue Feb 14, 2018 · 10 comments

Comments

@MalcolmAnderson
Copy link

MalcolmAnderson commented Feb 14, 2018

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
I could not find evidence that this bug has ever been reported.

Issue description:

Getting the laser beam to point up is not consistent.

Steps to reproduce:

  1. Place an energy cell on the ground
  2. Place a laser on top of the energy cell
  3. using the configurator try to get the laser to point up.

I have sometimes (about 3% of the time) gotten the laser to point up, but not light up
Other times (about 2% of the time) I have gotten the laser beam to shoot into the sky while the laser was pointed west.

The rest of the time, the laser insists on pointing horizontally.

Version (make sure you are on the latest version before reporting):

**Forge: 14.23.1.2559
**Mekanism: 1.12.2-9.4.3.330
Other relevant version:

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

[gist/pastebin/etc link here]

@MalcolmAnderson
Copy link
Author

MalcolmAnderson commented Feb 15, 2018

I can point the lasers down.
If I stand below something and click underneath something, the laser will point down.
However, if I stand above something and click on top of something, the laser will point horizontal.

@MalcolmAnderson
Copy link
Author

Updated comment with version number (1.12.2-9.4.3.330)

@tomelfring
Copy link
Collaborator

Hi @MalcolmAnderson,

For a block from mekanism to turn up/down you need to look atleast at an angle of 65 (rounded, so > 64.5) degree. You can see the value when you press F3 on the line saying Facing. The last value is the pitch. At > 65 it is placed facing down, at < -65 it's placed facing up.

Hope this helps with the placement of the blocks. If not, please let us know

@MalcolmAnderson
Copy link
Author

Hi @thommy101, hi @thiakil it's a year later, but I now have steps to reproduce.
Turns out it's not what I thought it was.
(And I'm looking for guidance as to whether I should resubmit this, or just leave this comment. Thoughts?)

Step 1, place a laser, facing any horizontal direction
Step 2, get above the laser (greater than 65 degrees - thanks again)
Step 3, click with configurator in rotate mode, right click the laser

The image (model, block on the ground) will not change location, but if you have it powered up, the laser will fire in the new rotated direction.

The model will catch up with the orientation, in 2 - 30 seconds (I haven't figured out the trigger yet)

2019-04-11_23 25 13
2019-04-11_23 25 20
2019-04-11_23 25 32

@thiakil
Copy link
Member

thiakil commented Apr 13, 2019

Thanks for the follow up, I think I might have come across this in my dev env once or twice but didn't think anything of it

@thiakil thiakil reopened this Apr 13, 2019
@thiakil thiakil added this to the 9.7.1 milestone Apr 13, 2019
@pupnewfster
Copy link
Member

Hi @MalcolmAnderson could you please double check this still happening for you with Mekanism 9.7.0. It seems to work properly for me with 9.7.0 (Though I can reproduce it as instructed against the 9.6.x versions).

@pupnewfster pupnewfster removed this from the 9.7.2 milestone Apr 23, 2019
@MalcolmAnderson
Copy link
Author

@pupnewfster - I will check that tonight.

@pupnewfster pupnewfster added this to the 9.7.3 milestone May 1, 2019
@pupnewfster
Copy link
Member

pupnewfster commented May 1, 2019

I think I found the issue, I thought it was fixed as the re connection to the energy cables was causing a block update making the laser reorient itself. However, without it being next to the cables it still happens. I think I just need to make sure that when rotating a block with the configurator it gets notified of an update.

Edit: It seems that it doesn't do it properly because the laser is telling our thing to not do a render update, but it still should be a relatively straight forward fix.

@MalcolmAnderson
Copy link
Author

Confirmed, image updates immediately in 9.7.0.

1 similar comment
@MalcolmAnderson
Copy link
Author

Confirmed, image updates immediately in 9.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants