Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve implementation of opening various Guis #5566

Merged
merged 9 commits into from Jul 22, 2019
Merged

Improve implementation of opening various Guis #5566

merged 9 commits into from Jul 22, 2019

Conversation

pupnewfster
Copy link
Member

@pupnewfster pupnewfster commented Jul 16, 2019 •
edited

Changes proposed in this pull request:

  • This should help mitigate any chance of duplication such as seen in Personal Chest Dupe Bug #5557.
  • Changed the way opening a Personal Chest (block variant) works. It now uses the openGui method.
  • Created a wrapper for openGui for opening Gui's for Items
  • Created a wrapper for openGui for opening Gui's for Entities (Robit)

@pupnewfster pupnewfster added this to the 9.8.0 milestone Jul 16, 2019
@thiakil
Copy link
Member

thiakil commented Jul 17, 2019

and in fact the client should never be telling the server what it opened

Agreed

@pupnewfster pupnewfster requested a review from thiakil July 19, 2019 13:45
@thiakil
Copy link
Member

thiakil commented Jul 20, 2019

This needs a bit more work, the whole way of opening the GUI is wrong :|

@pupnewfster pupnewfster changed the title Pass selected hotbar slot when opening personal chest Improve implementation of opening a Personal Chest Jul 20, 2019
@pupnewfster pupnewfster changed the title Improve implementation of opening a Personal Chest Improve implementation of opening various Guis Jul 20, 2019
@pupnewfster pupnewfster merged commit 50b53ae into 1.12 Jul 22, 2019
@pupnewfster pupnewfster deleted the personal_chest_dupe branch July 22, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiakil thiakil thiakil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pupnewfster @thiakil