Fix addition with negative int64_t

Negative part wasn't always handled, so expressions like (1 << 256) - 1 behaved incorrectly.
mekhovyyekulaki · Jul 11, 2022 · 4cacdb6 · 4cacdb6
1 parent 4dcf417
commit 4cacdb6
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/src/Bint/arithmetics.cpp b/src/Bint/arithmetics.cpp
@@ -81,16 +81,13 @@ Bint& Bint::operator += (const int64_t a) {
 	bool carry = false;
 	addUintWithCarry(number[0], a, carry);
 
-	if (carry) {
-		if (negA) {
-			for(int j = 1; j < (int)number.size(); j++) {
-				addUintWithCarry(number[j], -1, carry);
-			}
-		} else {
-			for(int j = 1; j < (int)number.size(); j++) {
-				addUintWithCarry(number[j], 0, carry);
-				if (!carry) break;
-			}
+	if (negA) {
+		for(int j = 1; j < (int)number.size(); j++) {
+			addUintWithCarry(number[j], -1, carry);
+		}
+	} else {
+		for(int j = 1; carry && j < (int)number.size(); j++) {
+			addUintWithCarry(number[j], 0, carry);
 		}
 	}