release v.1.0 #1
Conversation
There was a problem hiding this comment.
Changes Required 🛑
Hi @mekinus 👋
Nice job. You are doing quite well so far. Let's get a few things in order:
- Your repo does not have a descriptive README. This is a must for all our projects
- Stickler is failing; please find the errors and fix them.
- Remember this project is about building with background and gradient; thus the hero image is expected to be a background.
- The bottom part should contain four elements which are links (to other articles or #).
Kindly submit another code review request after making those fixes
Happy Coding ✌️
Ebuka Umeokonkwo
Github | Linkedin | Slack | Twitter
css/styles.css
Outdated
| right: 55px; | ||
| width: 90%; | ||
| display: flex; | ||
| background: linear-gradient(to top, #757575, #5F635F, #7D7D7D, #7C807C); |
There was a problem hiding this comment.
Expected "#5F635F" to be "#5f635f" (color-hex-case) [error]
Expected "#7D7D7D" to be "#7d7d7d" (color-hex-case) [error]
Expected "#7C807C" to be "#7c807c" (color-hex-case) [error]
css/styles.css
Outdated
| .nav-item { | ||
| margin-top: 10px; | ||
| flex: 1; | ||
| color: #F5F5F5; |
There was a problem hiding this comment.
Expected "#F5F5F5" to be "#f5f5f5" (color-hex-case) [error]
css/styles.css
Outdated
| } | ||
|
|
||
| .nav-item:hover { | ||
| background: linear-gradient(to right, #7C807C, #5F635F); |
There was a problem hiding this comment.
Expected "#7C807C" to be "#7c807c" (color-hex-case) [error]
Expected "#5F635F" to be "#5f635f" (color-hex-case) [error]
css/styles.css
Outdated
| } | ||
|
|
||
| .custom { | ||
| border: 1px solid linear-gradient(to top, #757575, #5F635F, #7D7D7D, #7C807C); |
There was a problem hiding this comment.
Expected "#5F635F" to be "#5f635f" (color-hex-case) [error]
Expected "#7D7D7D" to be "#7d7d7d" (color-hex-case) [error]
Expected "#7C807C" to be "#7c807c" (color-hex-case) [error]
css/styles.css
Outdated
| .custom { | ||
| border: 1px solid linear-gradient(to top, #757575, #5F635F, #7D7D7D, #7C807C); | ||
| border-radius: 10px; | ||
| background: linear-gradient(to top, #757575, #5F635F, #7D7D7D, #7C807C); |
There was a problem hiding this comment.
Expected "#5F635F" to be "#5f635f" (color-hex-case) [error]
Expected "#7D7D7D" to be "#7d7d7d" (color-hex-case) [error]
Expected "#7C807C" to be "#7c807c" (color-hex-case) [error]
css/styles.css
Outdated
| } | ||
|
|
||
| .nav-bar { | ||
| padding-left: 0px; |
There was a problem hiding this comment.
Unexpected unit (length-zero-no-unit) [error]
css/styles.css
Outdated
| color: #F5F5F5; | ||
| border-right: 1px solid #757575; | ||
| font-weight: bold; | ||
| font-family: "Arial"; |
There was a problem hiding this comment.
Unexpected missing generic font family (font-family-no-missing-generic-family-keyword) [error]
css/styles.css
Outdated
| flex: 1; | ||
| } | ||
|
|
||
| footer h6 span a { |
There was a problem hiding this comment.
Expected selector "footer h6 span a" to come before selector ".link-item a" (no-descending-specificity) [error]
Expected selector "footer h6 span a" to come before selector ".link-item a:hover" (no-descending-specificity) [error]
css/styles.css
Outdated
| color: #00A8E3; | ||
| } | ||
|
|
||
| footer h6 span a:hover { |
There was a problem hiding this comment.
Expected selector "footer h6 span a:hover" to come before selector ".link-item a:hover" (no-descending-specificity) [error]
css/styles.css
Outdated
| } | ||
|
|
||
| .border { | ||
| border-right: 1px solid #cccccc; |
There was a problem hiding this comment.
Expected "#cccccc" to be "#ccc" (color-hex-length) [error]
css/styles.css
Outdated
| margin-right: 20px; | ||
| } | ||
|
|
||
| .link-item a { |
There was a problem hiding this comment.
Expected selector ".link-item a" to come before selector "footer h6 span a:hover" (no-descending-specificity) [error]
css/styles.css
Outdated
|
|
||
| .link-item a { | ||
| text-decoration: none; | ||
| color: #00A8E3; |
There was a problem hiding this comment.
Expected "#00A8E3" to be "#00a8e3" (color-hex-case) [error]
There was a problem hiding this comment.
Changes Required
Hi @mekinus
Nice job. You are doing quite well so far. Let's get a few things in order:
- Your repo does not have a descriptive README. This is a must for all our projects
- Stickler is failing; please find the errors and fix them.
- Remember this project is about building with background and gradient; thus the hero image is expected to be a background.
- The bottom part should contain four elements which are links (to other articles or #).
Kindly submit another code review request after making those fixes
Happy Coding
Ebuka Umeokonkwo
Github | Linkedin | Slack | Twitter
@mekinus please refer to this. Please submit another code review request only after making the requested changes.
If you need assistance, you can reach me on slack.
Happy Coding ✌️
Ebuka Umeokonkwo
Github | Linkedin | Slack | Twitter
|
Fix all those issues, descriptive README file is at master branch |
There was a problem hiding this comment.
Changes Required!
Nice work making some of those changes. You are almost there.
Your stickler is still showing errors.
Please get it to turn green by correcting all the errors being pointed out.
Submit another code review after achieving this
Happy Coding ✌️
Ebuka Umeokonkwo
Github | Linkedin | Slack | Twitter
There was a problem hiding this comment.
Changes required 🛑
Hello @mekinus 🌟
Great work on this project, but we need to fix the issues below before moving on ⬇️
- Below is how the project is looking on my screen, please fix that and make it look like the original page:
After making the required changes please submit a new code review request
Good luck! 🍀
There was a problem hiding this comment.
Status :Changes Required
Hello @mekinus 👋
Good job implementing the changes but you have not finished all the required changes requested by previous TSEs. Please Fix them before making another review request.
Also, as @Redvanisation, the UI looks off on my screen as well. Refer the screenshot.
That's all!
Make these changes and submit for a code review, again
If you have any questions, let me know here or on slack and I will be glad to clarify with you. You can also reach me and connect with me on my social media or email.
Happy coding! 😄
Shivam Kaushik
Github Twitter Linkedin
no, it must be a browser issue of yours, because my navbar is flexible, it stretchs along with the size of screen, and it growths as well =) |
|
The navbar issue is not a problem of my page, my navbar is flexible, the previous TSEs not reported this issue to me as you can see at the first reviews. i just checked my page and it looks everything normal to me, i dont know why this review is taking too much time. |
Dear @mekinus, I wasn't talking about your Navbar. It looks fine (Except that it gets a little off when you hover over the links) I was talking about your UI. If you look at the screenshot properly, you'll realize that there's unnecessary space between the left and right of the screen whereas the design/content should span the whole width. If you have any queries, please let me know. |
already made the changes, and i want someone to review the code because im unable to submit the code again since is WAITING FOR REVIEW status all day long |
There was a problem hiding this comment.
Changes required 🛑
Hello @mekinus
1. The website has to look like the original page to be approved, the issue you are having is explained in my comment below, please implement it.
2. After that fix the background image to the center of the screen and you are done 😃
After making the required changes please submit a new code review request
Good luck! 🍀
| justify-content: space-between; | ||
| text-align: center; | ||
| border-radius: 5px; | ||
| } |
There was a problem hiding this comment.
You could align the navbar to center of the screen, the issue you are having is that your navbar has an absolute position so it will be displayed in a different position depending on the screen.
first, remove the right property and replace it with the following
left: 50%;
transform: translateX(-50%);
There was a problem hiding this comment.
I dont know what are you talking about , you are not being clear with your request i have to guess what im supposed to do , my main image is already centered, the nav bar is flexible the nav Will not move around the page, don't try to request things that arent required to pass the review, i already made the previous changes you asked yesterday, and now you are asking me to change other elements on my page that you not stated before.
There was a problem hiding this comment.
@mekinus to pass the review the page should look like the original page, this is the same change I requested before, the image isn't centered and the navbar isn't in the center, the comment I made was a hint on how to fix that on all screens.
The issue here is that you used position absolute so the navbar will stay in that specific position while the other elements will change depending on the screen size.
There was a problem hiding this comment.
The navbar Will shrink and stretch along with the page size, the navbar is at the center like the archive is showing, the image is at center, there is no Space to move the image , I still don't know what vou are talking about . You are asking different things each review you make , and as result slowing my progress in the Curriculum
There was a problem hiding this comment.
This is how the original page looks like:
And this is how your page is actually looking:
You are using a position absolute for the navbar it's not about the size but about the position, and this is what is causing this behavior, I gave you the code to fix that in the comment above, please fix it and submit for a re-review, I'm not asking you for things that aren't required 😃
There was a problem hiding this comment.
My page is not looking like that to me , its what im telling you , my page looks pretty normal. Like the original site
There was a problem hiding this comment.
Project Approved 👏
Hello @mekinus, you have done good job in this project
[Optional] The project is ok until the screen size is under 1366 width, if you rise this more, page is breaking. check that
Don't Forget to sumbit project completion form
Pon Muthu Selvam N
Feel free contact me
Github //@imhta | Twitter //@nponmuthuselvam
No description provided.