#263 OCL loader should throw an exception upon failure #264
Conversation
| ImportService importService = Context.getService(ImportService.class); | ||
|
|
||
| Import lastImport = importService.getLastImport(); | ||
| log.debug("Starting OCL importer"); | ||
| importer.run(zip); |
There was a problem hiding this comment.
This will never throw an exception back here, so we need to inspect the ocl import table that OCL uses to report information, including errors, about the executed jobs. I've seen a few different scenarios:
-
OCL fails to start an import at all, and so there is no ocl import entry written to the DB. This happens if, say, the server stopped during a previous import, and the previous import row was left with a null completion date. This will result in OCL logging stack traces to the console, but no row is written to the import table at all. So if the new import never started (no new row in the DB), we need to throw an exception here.
-
OCL starts, and reports an error in the import table. If we have a specific error, throw and exception with those details
-
OCL doesn't complete successfully and no specific error is logged. Not sure when or if this would happen, but it would be an error case.
No description provided.